[Bug 655616] Re: Press S or M does not work for more than one partition on error

[Colin Watson]

Thanks for your patch.

The third change to src/mountall.c appears unnecessary.  mnt->error was
already set to ERROR_NONE immediately above (we know that the 'if
(status)' block can't have been run, since that unconditionally
returns).

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is a direct subscriber.
https://bugs.launchpad.net/bugs/655616

Title:
  Press S or M does not work for more than one partition on error

Status in “mountall” package in Ubuntu:
  Triaged
Status in “mountall” source package in Lucid:
  Triaged

Bug description:
  Binary package hint: mountall

  On 10.04 Lucid Server/Desktop installations, if a filesystem that is
  specified in /etc/fstab cannot be mounted for some reason (USB disk
  not connected, partition deleted, samba share not available etc.) the
  boot process hangs displaying "Press S to Skip or M for Manual
  recovery".

  It works when there is only one partition on error, but with more than
  one, during the second message, pressing S/M does nothing and boot
  process hang there.

  As seen in bug #571444, a workaround is to press alt-sysrq-i and edit
  your fstab to remove missing drives.

  This bug looks like bug #571444, but on #571444 there is another issue
  which is about "no plymouth theme, so no message displayed". That's
  why I've opened a new bug specifically for "Press S or M does not work
  for more than one partition on error" problem.

  I've found when trying to debug/trace the problem that the problem
  come from plymouth_answer function at lines 3037/3038.

  the test :
          if ((plymouth_mnt != NULL) && (plymouth_mnt->error != plymouth_error))
                  return;
  is true as "plymouth_mnt->error" variable as been reset to "ERROR_NONE"

  I'll post a patch.