[Bug 584997] Re: TypeError in python wrapper, caused by swig change

[Stefano Rivera]

According to previous comments, this doesn't affect maverick

** Changed in: opensync (Ubuntu)
       Status: Triaged => Fix Released

-- 
TypeError in python wrapper, caused by swig change
https://bugs.launchpad.net/bugs/584997
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is a direct subscriber.

Status in A synchronization framework: New
Status in “opensync” package in Ubuntu: Fix Released
Status in “opensync” source package in Lucid: New

Bug description:
SWIG 1.3.37 introduced, rightly or wrongly, some changes in the way python is handled. This causes a crippling TypeError in python-opensync built with later versions of swig, such as the package in 10.04 lucid. The following patch will fix this problem, it will work ok with any version but is only required in builds on lucid. Please apply, python-opensync is crippled without this.

---
Description: Fix for change in SWIG after 1.3.36
 Upstream 0.2x branch is essentially unmaintained.
Forwarded: no
Author: Mark Ellis <mark at mpellis.org.uk>
Last-Update: 2010-05-24

diff -Nurp opensync-0.22.orig/wrapper/opensync.i opensync-0.22/wrapper/opensync.i
--- opensync-0.22.orig/wrapper/opensync.i	2007-03-27 12:49:09.000000000 +0100
+++ opensync-0.22/wrapper/opensync.i	2010-05-21 18:36:46.857447188 +0100
@@ -82,7 +82,7 @@ typedef struct {} OSyncHashTable;
 %extend OSyncChange {
 	OSyncChange(PyObject *obj=NULL) {
 		OSyncChange *change = NULL;
-		if (obj)
+		if ((obj) && (obj != Py_None))
 			change = (OSyncChange *)PyCObject_AsVoidPtr(obj);
 		else
 			change = osync_change_new();