[Bug 1861101] Re: [MIR]: dependency of bind9

Andreas Hasenack andreas at canonical.com
Tue Mar 17 18:41:06 UTC 2020 

python-maxminddb MIR request

Availability:
The package must already be in the Ubuntu universe, and must build for the architectures it is designed to work on.
- package is in universe: https://launchpad.net/ubuntu/+source/python-maxminddb
- package builds for amd64, arm64, armhf, ppc64el, s390x (i386 was dropped in the last upload, unknown at the moment if it has to be re-enabled for i386)

Rationale:
The package is a dependency of python-geoip2 which is to be promoted to main via MIR bug #1861101. See https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101/comments/17 for the application, and https://bugs.launchpad.net/ubuntu/+source/python-geoip2/+bug/1861101/comments/19 for the ACK

In general, we are demoting python-geoip (the legacy GeoIP1 support) and
want to replace it with geoip2. The unseeding of python-geoip already
happened in https://code.launchpad.net/~ahasenack/ubuntu-
seeds/+git/ubuntu/+merge/380547/


Security
- zero advisories at https://github.com/maxmind/MaxMind-DB-Reader-python/security/advisories

* http://cve.mitre.org/cve/search_cve_list.html
- https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=maxmind returned a hit for a javascript implementation
- geoip2, maxminddb, python-maxminddb, MaxMind-DB-Reader-python (the upstream name): no hits

* check OSS security mailing list (feed 'site:www.openwall.com/lists/oss-security <pkgname>' into search engine)
- "site:www.openwall.com/lists/oss-security maxminddb": no results
- "site:www.openwall.com/lists/oss-security maxmind": one hit:
  - https://www.openwall.com/lists/oss-security/2011/05/20/4
  - related to CVE-2007-0159 which was about the geoip1 C API
- "site:www.openwall.com/lists/oss-security python-maxminddb": no results
- "site:www.openwall.com/lists/oss-security python-maxmind": just ads as results
- "site:www.openwall.com/lists/oss-security MaxMind-DB-Reader-python": no results
- "site:www.openwall.com/lists/oss-security geoip2": no results

* Ubuntu CVE Tracker
* http://people.ubuntu.com/~ubuntu-security/cve/main.html
- no hits for maxminddb, geoip2, geoip, maxmind

* http://people.ubuntu.com/~ubuntu-security/cve/universe.html
- no hits for maxminddb, maxmind, geoip, geoip2

* http://people.ubuntu.com/~ubuntu-security/cve/partner.html 
- has no packages or CVEs at all

* Check for security relevant binaries. If any are present, this requires a more in-depth security review.
- the source package builds two binary packages: python3-maxminddb and python-maxminddb-doc The following is about these two binary packages.
* Executables which have the suid or sgid bit set.
- none

* Executables in /sbin, /usr/sbin.
- none (since it's a python module and its documentation, there are no executables)

* Packages which install services / daemons (/etc/init.d/*, /etc/init/*, /lib/systemd/system/*)
- no services

* Packages which open privileged ports (ports < 1024).
- none

* Add-ons and plugins to security-sensitive software (filters, scanners, UI skins, etc) 
- being a python module, it is meant to be used by other software. The current list of reverse-depends contains just one package and that is python3-geoip2 (src:python-geoip2). That package in turn is a dependency of "sopel", an IRC bot (according to its description).


Quality assurance:
* After installing the package it must be possible to make it working with a reasonable effort of configuration and documentation reading.
- python module is readily importable after installation

* The package must not ask debconf questions higher than medium if it is going to be installed by default. The debconf questions must have reasonable defaults.
- no debconf questions

* There are no long-term outstanding bugs which affect the usability of the program to a major degree. To support a package, we must be reasonably convinced that upstream supports and cares for the package.
- upstream bugs: 2 open, 17 closed: https://github.com/maxmind/MaxMind-DB-Reader-python/issues. Both open bugs are tagged with "enhancement" and are many years old
- ubuntu bugs: none other than the MIR
- debian bugs: none (https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=python-maxminddb)

* The package is maintained well in Debian/Ubuntu (check out the Debian PTS)
- https://tracker.debian.org/pkg/python-maxminddb
- note about new upstream version available (1.5.2), released in December 2019 (we are in sync with debian at 1.4.1, which is currently the most recent 1.4.x release)
- debian vcs has a few commits that weren't uploaded yet, not serious
- the doc package, being arch all, could have a multiarch hint/fix
- outdated standards version, but not by that much (4.4.0 vs 4.5.0)

* The package should not deal with exotic hardware which we cannot support.
- no exotic hardware involved

* If the package ships a test suite, and there is no obvious reason why it cannot work during build (e. g. it needs root privileges or network access), it should be run during package build, and a failing test suite should fail the build.
- currently 171 tests are run at build time.

* The package uses a debian/watch file whenever possible. In cases where this is not possible (e. g. native packages), the package should either provide a debian/README.source file or a debian/watch file (with comments only) providing clear instructions on how to generate the source tar file.
- a workingd/watch file is shipped:
$ uscan
uscan: Newest version of python-maxminddb on remote site is 1.5.2, local version is 1.4.1
uscan:    => Newer package available from
      https://pypi.debian.net/maxminddb/maxminddb-1.5.2.tar.gz
Successfully symlinked ../maxminddb-1.5.2.tar.gz to ../python-maxminddb_1.5.2.orig.tar.gz.


* It is often useful to run lintian --pedantic on the package to spot the most common packaging issues in advance
$ lintian -I --pedantic
I: python-maxminddb source: out-of-date-standards-version 4.4.0 (released 2019-07-07) (current is 4.5.0)
P: python-maxminddb source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
P: python-maxminddb source: package-does-not-install-examples examples/
P: python-maxminddb source: rules-requires-root-missing
- examples and insecure-copyright url are fixed in salsa:
  - https://salsa.debian.org/debian/python-maxminddb/-/commit/f94b9331c12093b12ea9dfa781dc4e566ec54963: ship examples
  - https://salsa.debian.org/debian/python-maxminddb/-/commit/4bb24ff8c21d539eb0112f13315556577ec3c7b8: copyright URI


* The package should not rely on obsolete or about to be demoted packages. That currently includes package dependencies on Python2 (without providing Python3 packages), and packages depending on GTK2. 
- no python2 package is produced, just python3


UI standards:
- not applicable


Dependencies:
* All binary dependencies (including Recommends:) must be satisfiable in main (i. e. the preferred alternative must be in main). If not, these dependencies need a separate MIR report (this can be a separate bug or another task on the main MIR bug) 
"""
$ check-mir
Checking support status of build dependencies...
 * debhelper-compat does not exist (pure virtual?)
 * dh-python binary and source package is in universe
 * python3-nose binary and source package is in universe
 * python3-mock binary and source package is in universe
 * python3-sphinx is in universe, but its source sphinx is already in main; file an ubuntu-archive bug for promoting the current preferred alternative
 * libmaxminddb-dev binary and source package is in universe

Checking support status of binary dependencies...
"""
- debhelper and dh-python ok
- python3 nose and mock are used for the test run at build time
- python3-sphinx is used to build docs
- libmaxminddb-dev comes from src:libmaxminddb with MIR at https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101 and conditionally approved in https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101/comments/5
- runtime deps:
$ dpkg -s python3-maxminddb | grep Depends
Depends: python3 (<< 3.9), python3 (>= 3.8~), python3:any, libc6 (>= 2.4), libmaxminddb0 (>= 1.0.2)

- there are no Recommends


Standards compliance
* The package should meet the FHS and Debian Policy standards. Major violations should be documented and justified. Also, the source packaging should be reasonably easy to understand and maintain.
- I did not identify important violations


Maintenance:
* All packages must have a designated "owning" team, regardless of complexity, which is set as a package bug contact.
- the server team shall own this package
- this is a simple python module
- d/rules uses debhelper and is simple
- d/* has a simple structure


Background information:
- package description is good



** Description changed:

  == MIR for libmaxminddb bug task ==
  (for the python-geoip2 bug task, please see https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101/comments/17)
+ (for the python-maxminddb bug task MIR, see https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101/comments/26)
  
  Availability:
  The package is in universe and builds for amd64 arm64 armhf i386 ppc64el s390x
  https://launchpad.net/ubuntu/+source/libmaxminddb/1.3.2-1
  
  Rationale:
  The package is a build dependency of the new bind9 9.16.x codebase.
  Upstream (maxminddb) deprecated the old libgeoip1 library which is what bind9 9.11.x used, and was used with bind9 up to 9.15.1
  Not building bind9 9.16.x with this support means a regression in bind9 when compared with previous ubuntu releases.
  This will also reduce our delta with debian, since they enable geoip2.
  See https://bugs.launchpad.net/ubuntu/+source/bind9/+bug/1866875
  See https://ftp.isc.org/isc/bind9/cur/9.16/CHANGES and look for the "5262" entry
  See https://downloads.isc.org/isc/bind9/9.15.2/RELEASE-NOTES-bind-9.15.2.html (which wasn't clear that geoip1 was removed, just that geoip2 was added)
  
  Security:
  * http://cve.mitre.org/cve/search_cve_list.html: Search in the National Vulnerability Database using the package as a keyword
  - no hits for "maxmind", "maxminddb", "libmaxminddb" other than a javascript implementation of this api
  
  * check OSS security mailing list (feed 'site:www.openwall.com/lists/oss-security <pkgname>' into search engine)
  - a search for "maxmind" returned https://www.openwall.com/lists/oss-security/2011/05/20/4 which is a CVE on the legacy version of this library. Other searches returned empty results.
  
  Ubuntu CVE Tracker
  * http://people.ubuntu.com/~ubuntu-security/cve/main.html
  - no hits
  
  * http://people.ubuntu.com/~ubuntu-security/cve/universe.html
  - no hits
  
  * http://people.ubuntu.com/~ubuntu-security/cve/partner.html
  - no hits
  
  * Check for security relevant binaries. If any are present, this requires a more in-depth security review.
  - The packages provide just two binaries: the library (static and dynamic), and one tool used for queries.
  
  * Executables which have the suid or sgid bit set.
  - none
  
   * Executables in /sbin, /usr/sbin.
  - none
  
  * Packages which install services / daemons (/etc/init.d/*, /etc/init/*, /lib/systemd/system/*)
  - none
  
  * Packages which open privileged ports (ports < 1024).
  - none
  
  * Add-ons and plugins to security-sensitive software (filters, scanners, UI skins, etc)
  - this can optionally be used by bind9 in ACLs
  Including bind9 in the CVE list, I found this old one which was related to the legacy geoip library:
  https://www.cvedetails.com/cve/CVE-2014-8680/. This wasn't a vulnerability in the library itself, though, but in bind.
  
  Quality assurance:
  * After installing the package it must be possible to make it working with a reasonable effort of configuration and documentation reading.
  - it's a library, used by other packages, so the configuration details will vary in complexity. For bind9, for example, there is https://kb.isc.org/docs/aa-01149
  
  * The package must not ask debconf questions higher than medium if it is going to be installed by default. The debconf questions must have reasonable defaults.
  - no debconf questions
  
  * There are no long-term outstanding bugs which affect the usability of the program to a major degree. To support a package, we must be reasonably convinced that upstream supports and cares for the package.
  - there are no open bugs in ubuntu besides the MIR (https://bugs.launchpad.net/ubuntu/+source/libmaxminddb)
  - there are no open bugs in debian: https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=libmaxminddb
  - very few bugs open upstream: https://github.com/maxmind/libmaxminddb/issues
    - most tagged with "enhancement"
    - closed bugs list shows more activity: https://github.com/maxmind/libmaxminddb/issues?q=is%3Aissue+is%3Aclosed
  - debian tracker: https://tracker.debian.org/pkg/libmaxminddb
    - there doesn't seem to be much activity
    - there is a warning about cflags in the build logs, something we could fix
    - same for multiarch warnings
    - standards version can be updated
    - new upstream version available (1.4.2), not updated in debian. Perhaps because 1.4.0 and 1.4.1 are tagged with "DO NOT USE" by upstream (see https://github.com/maxmind/libmaxminddb/releases)
  
  * The package should not deal with exotic hardware which we cannot support.
  - no exotic hardware
  
  * If the package ships a test suite, and there is no obvious reason why it cannot work during build (e. g. it needs root privileges or network access), it should be run during package build, and a failing test suite should fail the build.
  - moure than a thousand tests are run at build time
  
  * The package uses a debian/watch file whenever possible. In cases where this is not possible (e. g. native packages), the package should either provide a debian/README.source file or a debian/watch file (with comments only) providing clear instructions on how to generate the source tar file.
  - there is a working d/watch file:
   uscan
  uscan: Newest version of libmaxminddb on remote site is 1.4.2, local version is 1.3.2
  uscan:    => Newer package available from
        https://github.com/maxmind/libmaxminddb/releases/download/1.4.2/libmaxminddb-1.4.2.tar.gz
  Successfully symlinked ../libmaxminddb-1.4.2.tar.gz to ../libmaxminddb_1.4.2.orig.tar.gz.
  
  * It is often useful to run lintian --pedantic on the package to spot the most common packaging issues in advance
  $ lintian -I --pedantic
  E: libmaxminddb changes: bad-distribution-in-changes-file unstable
  W: libmaxminddb source: incomplete-creative-commons-license cc-by-sa (paragraph at line 9)
  W: libmaxminddb source: tab-in-license-text debian/copyright (paragraph at line 58)
  I: libmaxminddb0: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libmaxminddb.so.0.0.7
  I: libmaxminddb source: testsuite-autopkgtest-missing
  P: libmaxminddb-dev: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
  P: libmaxminddb0: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
  P: mmdb-bin: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
  P: libmaxminddb source: file-contains-trailing-whitespace debian/control (line 67)
  P: libmaxminddb source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
  P: libmaxminddb source: package-uses-old-debhelper-compat-version 10
  P: libmaxminddb source: rules-requires-root-missing
  
  Of the above, we can probably easily fix hardening-no-bindnow and
  debhelper compat version. I'm not sure about DEP8 tests, as they might
  need network access.
  
  * The package should not rely on obsolete or about to be demoted packages. That currently includes package dependencies on Python2 (without providing Python3 packages), and packages depending on GTK2.
  - I didn't spot any such reliance on old or obsolete packages.
  
  Dependencies:
  * All binary dependencies (including Recommends:) must be satisfiable in main (i. e. the preferred alternative must be in main). If not, these dependencies need a separate MIR report (this can be a separate bug or another task on the main MIR bug)
  - runtime dependencies of libmaxminddb0:
    - Depends: libc6 (>= 2.14), Suggests: mmdb-bin
  - runtime dependencies of libmaxmibddb-dev:
    - Depends: libmaxminddb0 (= 1.3.2-1)
  - runtime dependencies of mmdb-bin:
    - Depends: libc6 (>= 2.17), libmaxminddb0 (>= 1.0.2)
  - build-dependencies include packages from universe, but these are used for running the tests:
    $ check-mir
    Checking support status of build dependencies...
     * libipc-run3-perl binary and source package is in universe
     * libtest-output-perl binary and source package is in universe
  
  Standards compliance: The package should meet the FHS and Debian Policy standards. Major violations should be documented and justified. Also, the source packaging should be reasonably easy to understand and maintain.
  - Old Standards-Version: 4.1.4 from april 2018 (current is  4.5.0.0 from 2020-01-20)
  - d/rules is small and easy to maintain
  - package uses debhelper, could just use an update in the dh level
  - I don't see any complications in the source package
  
  Maintenance: The package must have an acceptable level of maintenance corresponding to its complexity:
  * All packages must have a designated "owning" team, regardless of complexity, which is set as a package bug contact.
  - server team will own this package
  
  * Simple packages (e.g. language bindings, simple Perl modules, small command-line programs, etc.) might not need very much maintenance effort, and if they are maintained well in Debian we can just keep them synced
  - single library, with the usual runtime, -dev, and one binary tool packages
  - this package is already a sync from debian
  
  Background information:
  * The package descriptions should explain the general purpose and context of the package. Additional explanations/justifications should be done in the MIR report.
  - the descriptions in d/control are good

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to nginx in Ubuntu.
https://bugs.launchpad.net/bugs/1861101

Title:
  [MIR]: dependency of bind9

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-release-notes/+bug/1861101/+subscriptions

More information about the Ubuntu-server-bugs mailing list