[Bug 1738412] Re: Init script fails test on reload/restart because of faulty regex

[Andreas Hasenack]

** Description changed:

  [Impact]
+ The squid initscript has a guard against configuration mistakes that prevents the service from being disrupted if the current config has an invalid setting.
  
-  * An explanation of the effects of the bug on users and
+ This guard relies on the "squid -k parse" command which analyzes the
+ configuration and, in the case of a fatal problem, outputs the string
+ "FATAL: <reason>". The initscript parses that output to catch such
+ errors before further action is taken.
  
-  * justification for backporting the fix to the stable release.
+ There is a mistake in the expression that is looked for, though: instead
+ of "FATAL: ", the initscript is looking for "FATAL " (i.e., no ":"). The
+ consequence is that actions that would reload or restart the service end
+ up shutting the service down in the case of a configuration error.
  
-  * In addition, it is helpful, but not required, to include an
-    explanation of how the upload fixes this bug.
+ The change fixes the expression that is looked for, restoring the
+ functionality of the guard.
  
  [Test Case]
  
-  * detailed instructions how to reproduce the bug
+  * detailed instructions how to reproduce the bug
  
-  * these should allow someone who is not familiar with the affected
-    package to reproduce the bug and verify that the updated package fixes
-    the problem.
+  * these should allow someone who is not familiar with the affected
+    package to reproduce the bug and verify that the updated package fixes
+    the problem.
  
  [Regression Potential]
  
-  * discussion of how regressions are most likely to manifest as a result
+  * discussion of how regressions are most likely to manifest as a result
  of this change.
  
-  * It is assumed that any SRU candidate patch is well-tested before
-    upload and has a low overall risk of regression, but it's important
-    to make the effort to think about what ''could'' happen in the
-    event of a regression.
+  * It is assumed that any SRU candidate patch is well-tested before
+    upload and has a low overall risk of regression, but it's important
+    to make the effort to think about what ''could'' happen in the
+    event of a regression.
  
-  * This both shows the SRU team that the risks have been considered,
-    and provides guidance to testers in regression-testing the SRU.
+  * This both shows the SRU team that the risks have been considered,
+    and provides guidance to testers in regression-testing the SRU.
  
  [Other Info]
-  
-  * Anything else you think is useful to include
-  * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
-  * and address these questions in advance
+ 
+  * Anything else you think is useful to include
+  * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
+  * and address these questions in advance
  
  [Original Description]
  
  This is a very serious issue that got fixed upstream in:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800341
  
  It is also logged in the Ubuntu changelog as fixed in:
  
  squid3 (3.5.12-1) unstable; urgency=medium
    [ Mathieu Parent ]
    * Fix FATAL parsing before start/reload/restart (Closes: #800341)
  
  But is in fact not fixed.
  When I look in the source package I find two init scripts:
  squid3.rc and squid.rc. squid3.rc has the patch while squid.rc does not.
  
  The one being included in the package and deployed is the one that does
  not have the fix.
  
  I'm including a patch to fix this issue.
  Please push this out ASAP.

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1738412

Title:
  Init script fails test on reload/restart because of faulty regex

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1738412/+subscriptions