[Bug 1779400] Re: DEP8 fixes for xenial

Mon Jul 23 14:10:08 UTC 2018

** Description changed:

- [Impact] 
- The biggest impact of this bug is in future apache2 (and others) SRUs. The libapache2-mod-perl2 DEP8 tests are run everytime apache2 is updated, and without the fixes from here, these tests will always fail. Time will be spend in debugging them, and eventually the fix will be found, just like I did for my apache SRU (https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1766186).
+ [Impact]
+ The biggest impact of this bug is in future apache2 (and others) SRUs. The libapache2-mod-perl2 DEP8 tests are run everytime apache2 is updated, and without the fixes from here, these tests will always fail. Time will be spent in debugging them, and eventually the fix will be found, just like I did for my apache SRU (https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1766186).

  Then maybe the SRU team might be convinced to ignore this failure, or
  ask for a special run with these patches applied showing that the new
  apache is fixed.

  It's unfortunate that to fix a test error we need to push an update out
  to our users, but I believe in the end this helps them as well, because
  it's one more test that will be run for future apache2 updates.

  [Test Case]
  There is a PPA with test packages that can be used until these packages reach propoxed. I suggest an autopkgtest run like the following:

- 
- autopkgtest -o dep8-xenial-ppa -U -s --apt-pocket=proposed --setup-commands="sudo add-apt-repository -s -y -u ppa:ahasenack/libapache2-mod-perl2-dep8" -B libapache2-mod-perl2 -- qemu ./autopkgtest-xenial-amd64.img
+ autopkgtest -o dep8-xenial-ppa -U -s --apt-pocket=proposed --setup-
+ commands="sudo add-apt-repository -s -y -u ppa:ahasenack/libapache2-mod-
+ perl2-dep8" -B libapache2-mod-perl2 -- qemu ./autopkgtest-xenial-
+ amd64.img

  You will have to adjust the path for the autopkgtest image that you
  have. If you have none, create one with:

  autopkgtest-buildvm-ubuntu-cloud -a amd64 -v -r xenial

  That will create a autopkgtest-xenial-amd64.img file in your current
  directory.

- 
- [Regression Potential] 
+ [Regression Potential]
  This is just test suite update, but new binaries will be produced. If build-depends of libapache2-mod-perl2 changed dramatically in xenial, this could produce an incompatible set of binaries, which would be a bug we would want to track down if happened.

  [Other Info]
  Here is a run with the packages from the aforementioned PPA: http://people.ubuntu.com/~ahasenack/deb8-modperl2-xenial-ppa/
- 

  == Original Description ==
  There are two DEP8 tests that are failing constantly in xenial:
  t/apache/read.t
  t/filter/in_bbs_inject_header.t

  See http://autopkgtest.ubuntu.com/packages/liba/libapache2-mod-
  perl2/xenial/amd64

  Debian has fixed them:
  libapache2-mod-perl2 (2.0.10-2) unstable; urgency=medium

    * Patch the test suite for Apache 2.4.24 compatibility.
      Thanks to Stefan Fritsch. (Closes: #849082)

   -- Niko Tyni <ntyni at debian.org>  Sun, 25 Dec 2016 11:51:10 +0200

  This is the diff:
  https://git.launchpad.net/ubuntu/+source/libapache2-mod-perl2/commit/?h=debian/buster&id=1a0e6c046960f816f0089d8d164f7fa9b077719f

  We should backport these to the xenial package, because libapache2-mod-
  perl2 is in the dependency tree of apache2 DEP8 tests and any apache2
  update will trigger these test failures. Artful and higher already have
  the fixes.

** Description changed:

  [Impact]
  The biggest impact of this bug is in future apache2 (and others) SRUs. The libapache2-mod-perl2 DEP8 tests are run everytime apache2 is updated, and without the fixes from here, these tests will always fail. Time will be spent in debugging them, and eventually the fix will be found, just like I did for my apache SRU (https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1766186).