[Bug 1736943] Re: 9.10.3.dfsg.P4-8ubuntu1.9 - keep on crashing on Ubuntu 16.04

[Andreas Hasenack]

In order to reach that INSIST(0) code, type.sa.sa_family needs to be something other than AF_INET, AF_INET6 or AF_UNIX:
void
isc_netaddr_fromsockaddr(isc_netaddr_t *t, const isc_sockaddr_t *s) {
        int family = s->type.sa.sa_family;
        t->family = family;
        switch (family) {
        case AF_INET:
                t->type.in = s->type.sin.sin_addr;
                t->zone = 0;
                break;
        case AF_INET6:
                memmove(&t->type.in6, &s->type.sin6.sin6_addr, 16);
#ifdef ISC_PLATFORM_HAVESCOPEID
                t->zone = s->type.sin6.sin6_scope_id;
#else
                t->zone = 0;
#endif
                break;
#ifdef ISC_PLATFORM_HAVESYSUNH
        case AF_UNIX:
                memmove(t->type.un, s->type.sunix.sun_path, sizeof(t->type.un));
                t->zone = 0;
                break;
#endif
        default:
                INSIST(0);
        }
}


>From the crash file:
(gdb) frame 4
#4  0x00007f2e236f1518 in isc_netaddr_fromsockaddr (t=t at entry=0x7f2e1dc06720, s=s at entry=0x7f2e0b046590) at ../../../lib/isc/netaddr.c:358
358	in ../../../lib/isc/netaddr.c
(gdb) p s->type.sa.sa_family
$9 = 57054
(gdb) 

That's odd, that looks like the port number:
(gdb) p s->type.sin
$13 = {sin_family = 57054, sin_port = 57054, sin_addr = {s_addr = <redacted>}, sin_zero = "\336\336\336\336\336\336\336", <incomplete sequence \336>}

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to bind9 in Ubuntu.
https://bugs.launchpad.net/bugs/1736943

Title:
  9.10.3.dfsg.P4-8ubuntu1.9 - keep on crashing on Ubuntu 16.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bind9/+bug/1736943/+subscriptions