[Bug 1535494] Re: Fix numa_node_to_cpus patch

[Serge Hallyn]

** Description changed:

+ =============================================
+ SRU Justification
+ same justification as for bug 1358835.  It would
+ be great to have the same test cases run as in that
+ bug.
+ =============================================
+ 
  In bug 1358835 we applied a fix to supress a warning.  The patch is different
  from upstream (and appears wrong).
  
  In particular,
  
  +               if (numa_bitmask_isbitset(numa_nodes_ptr, node)) {
  
  becomes
  
  +               if (f) {
  
  Switch to a straight cherrypick of the upstream patch.

** Description changed:

  =============================================
  SRU Justification
  same justification as for bug 1358835.  It would
  be great to have the same test cases run as in that
  bug.
+ 
+ The fix uploaded in that bug is wrong, in particular the diff between
+ the two patches includes:
+ 
+ -+              if (f) {
+ ++              if (numa_bitmask_isbitset(numa_nodes_ptr, node)) {
+ 
+ "if (f)" is a bogus test, f is simply an opened file.
  =============================================
  
  In bug 1358835 we applied a fix to supress a warning.  The patch is different
  from upstream (and appears wrong).
  
  In particular,
  
  +               if (numa_bitmask_isbitset(numa_nodes_ptr, node)) {
  
  becomes
  
  +               if (f) {
  
  Switch to a straight cherrypick of the upstream patch.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to numactl in Ubuntu.
https://bugs.launchpad.net/bugs/1535494

Title:
  Fix numa_node_to_cpus patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/numactl/+bug/1535494/+subscriptions