[Bug 1477198] Re: Stop doesn't works on Trusty

[Jorge Niedbalski]

The attached patch fixes the issue.

root at juju-testing-machine-15:/home/ubuntu# service haproxy start
 * Starting haproxy haproxy                                                                                                                                          [ OK ]
root at juju-testing-machine-15:/home/ubuntu# ps -fea |grep haproxy
haproxy  28338     1  0 15:29 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root at juju-testing-machine-15:/home/ubuntu# service haproxy stop
 * Stopping haproxy haproxy                                                                                                                                       [ OK ] 
root at juju-testing-machine-15:/home/ubuntu# ps -fea |grep haproxy
root at juju-testing-machine-15:/home/ubuntu# service haproxy status
haproxy not running.
root at juju-testing-machine-15:/home/ubuntu# service haproxy start
 * Starting haproxy haproxy                                                                                                                                            
                                                                                                                                                                  [ OK ]
root at juju-testing-machine-15:/home/ubuntu# ps -fea |grep haproxy
haproxy  28398     1  0 15:29 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root at juju-testing-machine-15:/home/ubuntu# service haproxy restart
 * Restarting haproxy haproxy                                                                                                                                           [ OK ]
root at juju-testing-machine-15:/home/ubuntu# ps -fea |grep haproxy
haproxy  28419     1  0 15:30 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
root at juju-testing-machine-15:/home/ubuntu# service haproxy stop
 * Stopping haproxy haproxy                                                                                                                                       [ OK ] 
root at juju-testing-machine-15:/home/ubuntu# service haproxy status
haproxy not running.


** Description changed:

  [Description]
  
  The stop method is not working properly. I removed the --oknodo &&
  --quiet and is returning (No /usr/sbin/haproxy found running; none
  killed)
  
  I think this is a regression caused by the incorporation of this lines
  on the stop method:
  
  +	for pid in $(cat $PIDFILE); do
  +		start-stop-daemon --quiet --oknodo --stop \
  +			--retry 5 --pid $pid --exec $HAPROXY || ret=$?
  
  root at juju-machine-1-lxc-0:~# service haproxy status
  haproxy is running.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        1513     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy restart
   * Restarting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2277     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy restart
   * Restarting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2523     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy stop
   * Stopping haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2584     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy start
   * Starting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2591       1  0 14:34 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2610     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy
+ 
+ [Impact]
+ 
+ - 'service stop/restart' doesn't works properly.
+ 
+ [Test Case]
+ 
+ - Install latest haproxy package.
+ - Run service haproxy restart
+  * Restarting haproxy haproxy
+    ...done.
+ root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
+ haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
+ haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
+ 
+ - Run service haproxy stop
+ 
+ root at juju-machine-1-lxc-0:~# service haproxy stop
+  * Stopping haproxy haproxy
+    ...done.
+ root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
+ haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
+ haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
+ 
+ [Other info]
+ 
+ None

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to haproxy in Ubuntu.
https://bugs.launchpad.net/bugs/1477198

Title:
  Stop doesn't works on Trusty

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1477198/+subscriptions