[Bug 1391322] Re: [ubuntu- 14.10] librtas: fixes for LE support

Steve Langasek steve.langasek at canonical.com
Tue Jan 20 17:54:39 UTC 2015


Hello bugproxy, or anyone else affected,

Accepted librtas into trusty-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/librtas/1.3.13-1~14.04
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Description changed:

+ [Justification]
+ librtas is an interface to a hardware management system specific to IBM POWER servers.  It is built for Ubuntu's powerpc and ppc64el architectures.  However, the version in Ubuntu 14.04 lacks full support for running on a little-endian host (ppc64el); and because powerpc is a 32-bit host OS its usage on IBM POWER servers is minimal.  This is a hardware-enablement SRU to fix behavior of librtas on ppc64el.
+ 
+ [Test case]
+ Proper functioning of librtas to be confirmed by IBM.
+ 
+ [Regression potential]
+ The new upstream version of librtas includes endianness fixes and new APIs.  The current package is of minimal utility on powerpc and is known to not work on ppc64el.  Risk of regression is negligible.
+ 
+ 
  ---Problem Description---
  Please include these additional patches to fix support for LE.
-   
- Machine Type = POWER8 
-  
-  
- Userspace tool common name: rtas_errd 
-  
- Userspace package: librtas 
+ 
+ Machine Type = POWER8
+ 
+ Userspace tool common name: rtas_errd
+ 
+ Userspace package: librtas
  
  Please pull below patchset from upstream.
  
  upstream repo : git://git.code.sf.net/p/librtas/code
  
- 
  commit 1d54a4a346f9111e1326dfdec756fd78360add42
  Author: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  Date:   Fri Oct 17 10:18:40 2014 -0400
  
-     When we pass _hi and _lo 32bits of a 64bit value, we
-     should convert the host endian value carefully.
-     
-     i.e,
-             X_hi = htobe32(BITS32_HI(X))
-             X_lo = htobe32(BITS32_LO(X))
-     
-     and not :
-             X_hi = BITS32_HI(htobe64(X))
-     
-     NOTE: This patch is untested, but I believe this patch
-     is good to have than the current faulty conversion.
-     
-     This patch fixes all such occurrences in librtas.
-     
-     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
+     When we pass _hi and _lo 32bits of a 64bit value, we
+     should convert the host endian value carefully.
+ 
+     i.e,
+             X_hi = htobe32(BITS32_HI(X))
+             X_lo = htobe32(BITS32_LO(X))
+ 
+     and not :
+             X_hi = BITS32_HI(htobe64(X))
+ 
+     NOTE: This patch is untested, but I believe this patch
+     is good to have than the current faulty conversion.
+ 
+     This patch fixes all such occurrences in librtas.
+ 
+     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
  
  commit e5541e1a5c83ce47cc492abcd7343d65763dcefe
  Author: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  Date:   Fri Oct 17 10:17:28 2014 -0400
  
-     Use rpm macros for standard paths
-     
-     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
+     Use rpm macros for standard paths
+ 
+     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
  
  commit 8ef7f827e28e3cd284f6be5686a987786be7502d
  Author: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  Date:   Fri Oct 17 10:16:16 2014 -0400
  
-     This patch fixes the conversion of args for paltform-dump call.
-     platform dump passes 64bit values as, a pair of 32bit values.
-     val_hi and val_lo. So when we convert a value 'X' to 32bit hi and lo
-     values in BE, we should follow the below approach :
-     
-     X_hi = htobe32(BITS32_HI(X))
-     X_lo = htobe32(BITS32_LO(X))
-     
-     and NOT
-     X_tmp = htobe64(X);
-     X_hi = BITS32_HI(X_tmp), X_lo = BITS32_LO(X_tmp)
-     
-     This patch has been tested with rtas_errd/extract_platdump to retrieve a
-     dump from FSP.
-     
-     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
+     This patch fixes the conversion of args for paltform-dump call.
+     platform dump passes 64bit values as, a pair of 32bit values.
+     val_hi and val_lo. So when we convert a value 'X' to 32bit hi and lo
+     values in BE, we should follow the below approach :
+ 
+     X_hi = htobe32(BITS32_HI(X))
+     X_lo = htobe32(BITS32_LO(X))
+ 
+     and NOT
+     X_tmp = htobe64(X);
+     X_hi = BITS32_HI(X_tmp), X_lo = BITS32_LO(X_tmp)
+ 
+     This patch has been tested with rtas_errd/extract_platdump to retrieve a
+     dump from FSP.
+ 
+     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
  
  commit 52263814c46210b51e564748050299620726dfd1
  Author: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  Date:   Fri Oct 17 10:12:54 2014 -0400
  
-     Fix LE parsing of SRC/FRU events
-     
-     Signed-off-by: Thomas L Falcon <tlfalcon at linux.vnet.ibm.com>
-     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
+     Fix LE parsing of SRC/FRU events
+ 
+     Signed-off-by: Thomas L Falcon <tlfalcon at linux.vnet.ibm.com>
+     Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
  
  commit ac0a91d2730740cd279d80ccd4c83b0a04827d1d
  Author: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  Date:   Fri Oct 17 10:10:29 2014 -0400
  
-     LE Support for SRC/FRU events
-     
-     Signed-off-by: Nathan Fontenot <nfont at linux.vnet.ibm.com>
+     LE Support for SRC/FRU events
+ 
+     Signed-off-by: Nathan Fontenot <nfont at linux.vnet.ibm.com>
  
  @ Canonical,
  
  We have recently made new upstream release (v1.3.13). If you are fine
  please pull new version.. -OR- just the patches mentioned here..
  
  -Vasant

** Changed in: librtas (Ubuntu Trusty)
       Status: New => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to librtas in Ubuntu.
https://bugs.launchpad.net/bugs/1391322

Title:
  [ubuntu- 14.10] librtas: fixes for LE support

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/librtas/+bug/1391322/+subscriptions



More information about the Ubuntu-server-bugs mailing list