[Bug 1328521] Re: curtin hook does not execute /opt/curtin/finalize

[Newell Jensen]

** Description changed:

  As reported by Gabriel (and Blake)
- There is a small [but crippling] bug in:                                                                                                                                                     
-                                                                                                                                                                                    
- http://bazaar.launchpad.net/~curtin-dev/curtin/trunk/view/head:/curtin/commands/hook.py#L41                                                                                        
-                                                                                                                                                                                    
- that particular join will not have the desired effect. The second parameter must not contain a leading /. or it will become the root path.                                         
-                                                                                                                                                                                    
- >>> import os                                                                                                                                                                      
- >>>                                                                                                                                                                                
- >>> root_p = "/root"                                                                                                                                                               
- >>> os.path.join(root_p, '/opt/curtin')                                                                                                                                            
- '/opt/curtin'                                                                                                                                                                      
- >>> os.path.join(root_p, 'opt/curtin')                                                                                                                                             
+ There is a small [but crippling] bug in:
+ 
+ http://bazaar.launchpad.net/~curtin-
+ dev/curtin/trunk/view/head:/curtin/commands/hook.py#L41
+ 
+ that particular join will not have the desired effect. The second
+ parameter must not contain a leading /. or it will become the root path.
+ 
+ >>> import os
+ >>>
+ >>> root_p = "/root"
+ >>> os.path.join(root_p, '/opt/curtin')
+ '/opt/curtin'
+ >>> os.path.join(root_p, 'opt/curtin')
  '/root/opt/curtin'
+ 
+ 
+ SRU curtin
+ ==========
+ 
+ [Impact]
+ 
+  This bug doesn't allow curtin to execute /opt/curtin/finalize which is
+ needed for finalizing the provided directory for the default target
+ mount point during a curtin installation.
+ 
+ This fix needs to be backported to the stable release so that program
+ can have the originally intended functionality.
+ 
+ This upload fixes the bug by enabling the finalize script to execute as
+ originally intended.
+ 
+ 
+ [Test Case]
+ 
+ To reproduce the bug, follow the original bug report description.  This
+ can be verified by using a Python interpreter and the code changes that
+ the patch supplies.
+ 
+ 
+ [Regression Potential] 
+ 
+ Since the script was not executing as originally intended there would
+ only be regressions in the event that other "band-aid" fixes were
+ committed upstream to circumvent the undesirable effect that this had.
+ This isn't the case so we believe the probability of this causing a
+ regression is low.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to curtin in Ubuntu.
https://bugs.launchpad.net/bugs/1328521

Title:
  curtin hook does not execute /opt/curtin/finalize

To manage notifications about this bug go to:
https://bugs.launchpad.net/curtin/+bug/1328521/+subscriptions