[Bug 1267798] [NEW] Init script returns exit 0 for status when default has START=no

[Greg Sutcliffe]

Public bug reported:

Currently, if one sets START=no in /etc/default/puppetmaster, the init
script will exit with exit-code 0, regardless of whether the service is
running or not. In the case where you have a puppet manifest like:

service { 'puppetmaster': ensure => stopped }

Puppet will try to stop the service on every agent run, because status
is returning zero, so Puppet thinks it is running.

This issue was fixed upstream in this commit:

https://github.com/puppetlabs/puppet/commit/e48902a7d881e84861d366af5ff88fc0146037da

As it's a one-liner, could this be backported into the Ubuntu packages?

Thanks,
Greg

-- System Information:
Description:	Ubuntu 12.04.3 LTS
Release:	12.04
Architecture: amd64 (x86_64)

puppetmaster:
  Installed: 2.7.11-1ubuntu2.7
  Candidate: 2.7.11-1ubuntu2.7
  Version table:
 *** 2.7.11-1ubuntu2.7 0
        500 http://nova.clouds.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 Packages

** Affects: puppet (Ubuntu)
     Importance: Undecided
         Status: New

** Description changed:

- Currently, if one sets START=no in /etc/default/puppetmaster, the init script will
- exit with exit-code 0, regardless of whether the service is running or not. In the
- case where you have a puppet manifest like:
+ Currently, if one sets START=no in /etc/default/puppetmaster, the init
+ script will exit with exit-code 0, regardless of whether the service is
+ running or not. In the case where you have a puppet manifest like:
  
  service { 'puppetmaster': ensure => stopped }
  
- Puppet will try to stop the service on every agent run, because status is returning
- zero, so Puppet thinks it is running.
+ Puppet will try to stop the service on every agent run, because status
+ is returning zero, so Puppet thinks it is running.
  
  This issue was fixed upstream in this commit:
  
  https://github.com/puppetlabs/puppet/commit/e48902a7d881e84861d366af5ff88fc0146037da
  
  As it's a one-liner, could this be backported into the Debian packages?
  
  Thanks,
  Greg
  
  -- System Information:
  Description:	Ubuntu 12.04.3 LTS
  Release:	12.04
  Architecture: amd64 (x86_64)
  
  puppetmaster:
-   Installed: 2.7.11-1ubuntu2.7
-   Candidate: 2.7.11-1ubuntu2.7
-   Version table:
-  *** 2.7.11-1ubuntu2.7 0
-         500 http://nova.clouds.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 Packages
+   Installed: 2.7.11-1ubuntu2.7
+   Candidate: 2.7.11-1ubuntu2.7
+   Version table:
+  *** 2.7.11-1ubuntu2.7 0
+         500 http://nova.clouds.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 Packages

** Description changed:

  Currently, if one sets START=no in /etc/default/puppetmaster, the init
  script will exit with exit-code 0, regardless of whether the service is
  running or not. In the case where you have a puppet manifest like:
  
  service { 'puppetmaster': ensure => stopped }
  
  Puppet will try to stop the service on every agent run, because status
  is returning zero, so Puppet thinks it is running.
  
  This issue was fixed upstream in this commit:
  
  https://github.com/puppetlabs/puppet/commit/e48902a7d881e84861d366af5ff88fc0146037da
  
- As it's a one-liner, could this be backported into the Debian packages?
+ As it's a one-liner, could this be backported into the Ubuntu packages?
  
  Thanks,
  Greg
  
  -- System Information:
  Description:	Ubuntu 12.04.3 LTS
  Release:	12.04
  Architecture: amd64 (x86_64)
  
  puppetmaster:
    Installed: 2.7.11-1ubuntu2.7
    Candidate: 2.7.11-1ubuntu2.7
    Version table:
   *** 2.7.11-1ubuntu2.7 0
          500 http://nova.clouds.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 Packages

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1267798

Title:
  Init script returns exit 0 for status when default has START=no

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1267798/+subscriptions