[Bug 1314598] Re: [Precise] drbd8: drbdadm does not run compat mode when DRBD_DONT_WARN_ON_VERSION_MISMATCH is set

[Stefan Bader]

** Description changed:

  SRU Justification:
  
  Impact: This is for now only relevant for the 12.04 (Precise) backport
  of drbd-utils 8.4.x as that uses the 8.3 compat mode when running with a
  linux kernel module from kernel 3.2.x. Problem is the following code:
  
-         if (!getenv("DRBD_DONT_WARN_ON_VERSION_MISMATCH"))
-                 warn_on_version_mismatch();
+         if (!getenv("DRBD_DONT_WARN_ON_VERSION_MISMATCH"))
+                 warn_on_version_mismatch();
  
-         maybe_exec_drbdadm_83(argv);
+         maybe_exec_drbdadm_83(argv);
  
  Because maybe_ecec_drbdadm_83 relies on a structure being filled in
  warn_on_version_mismatch only.
  
- Fix: Move the code to set up the version number from
- warn_on_version_mismatch() outside, so it is always called.
+ Fix: Add a call to setup the kernel version to maybe_exec_drbdadm_83.
+ This function does the full setup only once already.
  
  Testcase: When running a 3.2 kernel and the 8.4.x version of drbd8-utils
  "drbdadm --version" without DRBD_DONT_WARN_ON_VERSION_MISMATCH set in
  the environment, It will return a 8.3 version number. Otherwise a
  version 8.4. When the bug is fixed it has to be a 8.3 version in both
  cases.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to drbd8 in Ubuntu.
https://bugs.launchpad.net/bugs/1314598

Title:
  [Precise] drbd8: drbdadm does not run compat mode when
  DRBD_DONT_WARN_ON_VERSION_MISMATCH is set

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/drbd8/+bug/1314598/+subscriptions