[Bug 1081247] Re: maas provider releases all nodes it did not allocate [does not play well with others]

[James Page]

** Description changed:

+ [Impact]
+ juju destroy-environment destroys all machines allocated to the MAAS user being used in the environment, not just the ones owned by Juju.
+ 
+ [Test Case]
+ Allocate machines using maas-cli
+ juju bootstrap
+ juju destroy-environment
+ (all machines are terminated and powered off)
+ 
+ [Regression Potential]
+ The fix is limited to the MAAS provider in the codebase; so regression potential is limited in scope of provider.
+ 
+ [Original Bug Report]
  juju/agents/provision.py process_machines says:
  
   | """Ensure the currently running machines correspond to state.
   |
   | At the end of each process_machines execution, verify that all
   | running machines within the provider correspond to machine_ids within
   | the topology. If they don't then shut them down.
   |
   | Utilizes concurrent execution guard, to ensure that this is only being
   | executed at most once per process
   ...
   | # Terminate all unused juju machines running within the cluster.
  
  This logic/description is clearly fundamentally flawed and means that a
  given maas user cannot have more than one juju environment on the same
  maas cluster.
  
  It also means that if a user is using juju, then they cannot deploy a
  node in *any* other way, or juju bootstrap node will kill it for them.
  
  I did not explicitly check, but I would suspect/hope that this behavior
  is not the same as the EC2 provider.  Ie, I do not expect that juju
  kills all my running EC2 instances if I choose to type 'juju bootstrap'.
  
  Related bugs:
-  * bug 1237398: "You'll need a separate MAAS key for each Juju environment" is wrong.
-  * bug 1229275: juju destroy-environment also destroys nodes that are not controlled by juju
-  * bug 1239488: Juju api client cannot distinguish between environments
+  * bug 1237398: "You'll need a separate MAAS key for each Juju environment" is wrong.
+  * bug 1229275: juju destroy-environment also destroys nodes that are not controlled by juju
+  * bug 1239488: Juju api client cannot distinguish between environments

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to juju-core in Ubuntu.
https://bugs.launchpad.net/bugs/1081247

Title:
  maas provider releases all nodes it did not allocate [does not play
  well with others]

To manage notifications about this bug go to:
https://bugs.launchpad.net/juju/+bug/1081247/+subscriptions