[Bug 986973] Re: Facter bug causes puppet to hang

[Robie Basak]

(this appears fixed in Saucy, so just the Precise SRU needed)

** Description changed:

+ [Impact]
+ 
+ "puppet apply" hangs about 20% of the time on affected servers. This
+ affects users using puppet without a puppetmaster. The normal use case
+ is to make "puppet apply" run regularly. This causes hung puppet
+ processes to build up, eventually exhausting system resources.
+ 
+ For those users using puppet without a puppetmaster, this makes puppet
+ unusable.
+ 
+ [Workaround]
+ 
+ Run puppet with the timeout command. For example:
+ 
+      timeout -k 300s 290s puppet apply /etc/puppet/manifests/site.pp
+ 
+ [Development Fix]
+ 
+ Fixed upstream by removing some unnecessary thread-exclusive locks that
+ were evidently causing a deadlock when the facter module is used from
+ puppet in the "puppet apply" case.
+ 
+ [Stable Fix]
+ 
+ Development fix cherry-picked from upstream.
+ 
+ [Test Case]
+ 
+ 1. apt-get install -y puppet
+ 2. cat > /etc/puppet/manifests/site.pp <<EOT
+ file { '/tmp/foo': content => 'bar'; }
+ EOT
+ 3. successes=0; failures=0; for i in `seq 1 100`; do timeout -k 35s 30s puppet apply /etc/puppet/manifests/site.pp; rv=$?; echo "Exit status $rv"; if [ $rv -eq 0 ]; then successes=$(($successes+1)); else failures=$(($failures+1)); fi; done; echo "Successses: $successes; failures: $failures"
+ 
+ Expected result: Successes: 100; failures: 0
+ Actual result (approx): Successes: 80; failures: 20
+ 
+ Note that this is dependent on a race condition, so this is difficult to
+ reproduce. I have not managed to reproduce the fault reliably except on
+ particular servers where it happens to occur. I have a server where it
+ is happening, and the fix eliminates the problem, and am prepared to use
+ this for -proposed verification.
+ 
+ [Regression Potential]
+ 
+ The code that runs inside each lock section is trivial, clearly does not
+ need a lock, and upstream concurs:
+ http://projects.puppetlabs.com/issues/12723
+ 
+ [Original Description]
+ 
  I found a bug with Facter that's affecting the version distributed with
  12.04. Upstream bug report here:
  http://projects.puppetlabs.com/issues/12723 This makes puppet completely
  unusable for us unless this change is applied.
  
  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: facter 1.6.5-1ubuntu1
  ProcVersionSignature: Ubuntu 3.2.0-23.36-virtual 3.2.14
  Uname: Linux 3.2.0-23-virtual x86_64
  ApportVersion: 2.0.1-0ubuntu5
  Architecture: amd64
  Date: Sun Apr 22 19:11:56 2012
  Ec2AMI: ami-2616cd4f
  Ec2AMIManifest: (unknown)
  Ec2AvailabilityZone: us-east-1b
  Ec2InstanceType: c1.medium
  Ec2Kernel: aki-825ea7eb
  Ec2Ramdisk: unavailable
  PackageArchitecture: all
  ProcEnviron:
-  LC_CTYPE=en_US.UTF-8
-  TERM=xterm
-  LANG=en_US.UTF-8
-  SHELL=/usr/bin/zsh
+  LC_CTYPE=en_US.UTF-8
+  TERM=xterm
+  LANG=en_US.UTF-8
+  SHELL=/usr/bin/zsh
  SourcePackage: facter
  UpgradeStatus: No upgrade log present (probably fresh install)

** Changed in: facter (Ubuntu Precise)
       Status: New => In Progress

** Changed in: facter (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to facter in Ubuntu.
https://bugs.launchpad.net/bugs/986973

Title:
  Facter bug causes puppet to hang

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/facter/+bug/986973/+subscriptions