[Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

[Robert Collins]

Quick code read - I think that this block:
    if (flags & NBD_FLAG_READ_ONLY) {
        int read_only = 1;       
        TRACE("Setting readonly attribute");
            
        if (ioctl(fd, BLKROSET, (unsigned long) &read_only) < 0) { 
            int serrno = errno;
            LOG("Failed setting read-only attribute");
            return -serrno;
        }   
    }       

in nbd.c should be
    {
        int read_only = 0;
        if (flags & NBD_FLAG_READ_ONLY)
            read_only = 1;
        TRACE("Setting readonly attribute");
        if (ioctl(fd, BLKROSET, (unsigned long) &read_only) < 0) { 
            int serrno = errno;
            LOG("Failed setting read-only attribute");
            return -serrno;
        }   
    }

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to qemu-kvm in Ubuntu.
https://bugs.launchpad.net/bugs/1077838

Title:
  qemu-nbd -r -c taints device for subsequent usage, even after -d

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/1077838/+subscriptions