[Bug 1016673] [NEW] Extra forks on automount initialisation & HUP signal

[Dmitrijs Ledkovs]

Public bug reported:

Imported from Debian bug http://bugs.debian.org/678555:

Package: autofs
Version: 5.0.6-2
Severity: important
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch

After merging 5.0.6-2 for Ubuntu I have noticed that upstart init daemon
was tracking the wrong PID of the daemon. [1]

This resulted me into digging what has changed and I noticed the three
patches, which I have attached to this email.

These patches [0001-0003] do three things:

* Check mount.nfs version to be >= 1.1.1
* Check kernel version is >= 2.6.22
* Do above by calling nfs_version_check at pre-demonisation, hence
upstart ending up tracking `mount.nfs -V` call
* all for the sake of figuring out if probing optimisation can be used
(or something, not too sure):

"""
The change to have the kernel process text based mount options can
introduce lengthy timeout waits when attempting a mount to a host
that is not available.

To avoid these waits autofs should probe singleton mounts if it
thinks mount.nfs will pass text options to the kernel (which of
course implies the kernel supports this).
"""

But, mount.nfs 1.1.1 is acient and so is linux kernel 2.6.22... so I'm
thinking to make this a no-op. and simply remove those checks. See mine
Remove-*.patch attached.

With that patch I want to revert the upstream patches [0001-0003].

Setting priority to important as this is change of daemon behaviour and
resource waste to fork calls like this. Feel free to lower severity, if
you wish.

[1] Upstart does not rely on pidfiles, instead it counts forks/clones
and chooses the correct pid to track, such that it notices if it dies /
gets killed. This is more reliable than pidfiles. Upstart can also run
daemons in foreground mode.

-- 
Regards,
Dmitrijs.

** Affects: autofs (Ubuntu)
     Importance: Medium
     Assignee: Dmitrijs Ledkovs (dmitrij.ledkov)
         Status: Fix Committed

** Affects: autofs (Debian)
     Importance: Undecided
         Status: New

** Bug watch added: Debian Bug tracker #678555
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678555

** Changed in: autofs (Debian)
 Remote watch: None => Debian Bug tracker #678555

** Changed in: autofs (Ubuntu)
       Status: New => Triaged

** Changed in: autofs (Ubuntu)
       Status: Triaged => Fix Committed

** Changed in: autofs (Ubuntu)
   Importance: Undecided => Medium

** Changed in: autofs (Ubuntu)
     Assignee: (unassigned) => Dmitrijs Ledkovs (dmitrij.ledkov)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to autofs in Ubuntu.
https://bugs.launchpad.net/bugs/1016673

Title:
  Extra forks on automount initialisation & HUP signal

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1016673/+subscriptions