[Bug 1088053] Re: Kernel needs to provide FIFREEZE/FITHAW ioctl so that open-vm-dkms can build

[Joseph Salisbury]

Hi Nate,

It appears FIFREEZE AND FITHAW are already built into the kernel.

Here is the defines in ~/linux/include/linux/fs.h(Also in ~linux/include/uapi/linux/fs.h):
#define FIFREEZE        _IOWR('X', 119, int)    /* Freeze */
#define FITHAW          _IOWR('X', 120, int)    /* Thaw */


In ~linux/fs/ioctl.c, there is a switch for FIFREEZE AND FITHAW:
do_vfs_ioctl()

   case FIFREEZE:
                error = ioctl_fsfreeze(filp);
                break;

    case FITHAW:
                error = ioctl_fsthaw(filp);
                break;


These switch statements then call ioctl_fsfreeze() or ioctl_fsthaw():
static int ioctl_fsfreeze(struct file *filp)
{
        struct super_block *sb = filp->f_path.dentry->d_inode->i_sb;

        if (!capable(CAP_SYS_ADMIN))
                return -EPERM;

        /* If filesystem doesn't support freeze feature, return. */
        if (sb->s_op->freeze_fs == NULL)
                return -EOPNOTSUPP;

        /* Freeze */
        return freeze_super(sb);
}

ioctl_fsfreeze() then does a check to see if freeze is supported by the
filesystem.

Do you have a more complete log of the failure you are seeing when
vmsync doesn't compile?  If it was working prior to the v3.6 kernel,
then that would also indicate this is a regression versus a new feature
request.

** Changed in: linux (Ubuntu)
       Status: Confirmed => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to open-vm-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1088053

Title:
  Kernel needs to provide FIFREEZE/FITHAW ioctl so that open-vm-dkms can
  build

To manage notifications about this bug go to:
https://bugs.launchpad.net/open-vm-tools/+bug/1088053/+subscriptions