[Bug 1066115] Re: The landscape client plugin doesn't create the config file with the proper permissions

[Steve Langasek]

** Description changed:

  === Begin SRU Information ===
  [Impact]
-  * If an image does not have landscape-client installed inside it, and the
-    user provided landscape config, then:
-    a.) the landscape config file would be written with root:root permissions
-        so that the user that landscape runs as could not change it.
-    b.) the landscape package would not be installed.
+  * If an image does not have landscape-client installed inside it, and the
+    user provided landscape config, then:
+    a.) the landscape config file would be written with root:root permissions
+        so that the user that landscape runs as could not change it.
+    b.) the landscape package would not be installed.
  
-  * The fix here is just to install the landscape-client package.  This is
-    clearly what the user would want.
-    Additionally, no package installation occurs unless the user made that
-    request.  The fix for 'a' is also addressed by this because the file will
-    exist on disk with proper permissions before cloud-init writes it, and
-    will thus keep the same ownership.
+  * The fix here is just to install the landscape-client package.  This is
+    clearly what the user would want.
+    Additionally, no package installation occurs unless the user made that
+    request.  The fix for 'a' is also addressed by this because the file will
+    exist on disk with proper permissions before cloud-init writes it, and
+    will thus keep the same ownership.
  
  [Test Case]
-  * launch instance with landscape config in user-data like the following:
-    #cloud-config
-    apt_upgrade: True
-    apt_sources:
-     - source: deb $MIRROR $RELEASE-proposed main
-    landscape:
-      client:
-        url: "https://landscape.canonical.com/message-system"
-        ping_url: "http://landscape.canonical.com/ping"
-        data_path: "/var/lib/landscape/client"
-        http_proxy: "http://my.proxy.com/foobar"
-        tags: "server,cloud"
-  * upon investigation, /etc/landscape/client.conf should be owned
-    by 'landscape' user rather than root.
+  * launch instance with landscape config in user-data like the following:
+    #cloud-config
+    apt_upgrade: True
+    apt_sources:
+     - source: deb $MIRROR $RELEASE-proposed main
+    landscape:
+      client:
+        url: "https://landscape.canonical.com/message-system"
+        ping_url: "http://landscape.canonical.com/ping"
+        data_path: "/var/lib/landscape/client"
+        http_proxy: "http://my.proxy.com/foobar"
+        tags: "server,cloud"
+  * upon investigation, /etc/landscape/client.conf should be owned
+    by 'landscape' user rather than root.
  
- [Regression Potential] 
-  * This was broken before, so it is not likely to be broken worse now.
+ [Regression Potential]
+  * If a user with a generic user_data setup is assuming that the 'landscape' config will be applied only on those images which already have landscape-client installed, automatically installing landscape-client will be an unexpected a behavior change.
  
  === End SRU Information ===
- 
  
  When cloud-init runs and landscape-client is not installed, it creates
  /etc/landscape/client.conf owned as root:root, whereas landscape-client
  expects it to be landscape:root. The proper fix is although probably to
  require installation of landscape-client first, as it will create the
  file properly, and then landscape-client can update it.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to cloud-init in Ubuntu.
https://bugs.launchpad.net/bugs/1066115

Title:
  The landscape client plugin doesn't create the config file with the
  proper permissions

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1066115/+subscriptions