[Bug 1080985] Re: 'noblock' setting for resize_rootfs is broken

[Scott Moser]

** Description changed:

+ == Begin SRU Information ==
+ [Impact]
+  * Users who want to run filesystem resize without blocking first boot are not able to.  This is admittedly small impact, but is clearly broken code.
+  
+ [TestCase]
+  * launch an instance with userdata like:
+   #cloud-config
+   resize_rootfs: noblock
+  * run 'df' in instance, see root filesystem is not resized
+  * see /var/log/cloud-init.log showing that resizefs was ignored.
+ 
+ [Regression Potential]
+  * small chance for regression. Previous code checked a small list of values for a boolean value, and did nothing if it was not "true".  The change extends the check to also consider 'noblock'.
+ == End SRU Information ==
+ 
  resize_rootfs: noblock
  
  should tell the resize to occur in the background, but it will currently result in:
  Nov 20 04:51:45 ubuntu [CLOUDINIT] cc_resizefs.py[DEBUG]: Skipping module named resizefs, resizing disabled
  
  The fix is simple, in cloudinit/config/cc_resizefs.py:
  
-     log.warn("resize_root: %s" % resize_root)
-     if not util.translate_bool(resize_root) and resize_root not in ("noblock"):
-         log.debug("Skipping module named %s, resizing disabled", name)
-         return
+     log.warn("resize_root: %s" % resize_root)
+     if not util.translate_bool(resize_root) and resize_root not in ("noblock"):
+         log.debug("Skipping module named %s, resizing disabled", name)
+         return

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to cloud-init in Ubuntu.
https://bugs.launchpad.net/bugs/1080985

Title:
  'noblock' setting for resize_rootfs is broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1080985/+subscriptions