[Bug 584143] Re: qemu fails to set hdd serial number
Serge Hallyn
584143 at bugs.launchpad.net
Tue Mar 15 13:37:50 UTC 2011
** Description changed:
+ =========================================
+ SRU Justification:
+ 1. Impact: 'qemu -drive ...,serial=xyz' does not work
+ 2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing.
+ 3. patch: is in the description
+ 4. to reproduce: use '-drive ...,serial=xyz' option to qemu
+ 5. regression potential: this only changes one line which called sizeof on the wrong thing, so should not impact any other code.
+ =========================================
+
The -drive ...,serial=xyz option is broken, at least in 0.12. See
Debian bug#573439, http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=573439 for details.
The proposed fix from the original reporter:
--- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
- dinfo->on_write_error = on_write_error;
- dinfo->opts = opts;
- if (serial)
+ dinfo->on_write_error = on_write_error;
+ dinfo->opts = opts;
+ if (serial)
- strncpy(dinfo->serial, serial, sizeof(serial));
+ strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
- QTAILQ_INSERT_TAIL(&drives, dinfo, next);
- if (is_extboot) {
- extboot_drive = dinfo;
+ QTAILQ_INSERT_TAIL(&drives, dinfo, next);
+ if (is_extboot) {
+ extboot_drive = dinfo;
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to qemu-kvm in ubuntu.
https://bugs.launchpad.net/bugs/584143
Title:
qemu fails to set hdd serial number
More information about the Ubuntu-server-bugs
mailing list