[Bug 792985] [NEW] virt-manager fails if target system has no grep -q

[Richard Laager]

Public bug reported:

The nc -q autodetection code fails if the target system's grep does not
have a -q argument (quite the ironic coincidence). I believe -q is
specified by POSIX, but Solaris 11's /bin/grep does not support -q.
Redirecting to /dev/null works portably. (In fact, this is even
recommended in favor of -q for portability by GNU grep's man page.)

This needs to be changed in virt-manager's src/virtManager/console.py
(by adding a new patch) and libvirt's debian/patches/Autodetect-if-the-
remote-nc-command-supports-the-q-o.patch (and the updated patch
reapplied to src/remote/remote_driver.c).

BEFORE:
grep -q \"requires an argument\"
AFTER:
grep \"requires an argument\" >/dev/null

** Affects: libvirt (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: virt-manager (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: libvirt (Ubuntu)
   Importance: Undecided
       Status: New

** Description changed:

- Binary package hint: virt-manager
- 
  The nc -q autodetection code fails if the target system's grep does not
  have a -q argument (quite the ironic coincidence). I believe -q is
  specified by POSIX, but Solaris 11's /bin/grep does not support -q.
  Redirecting to /dev/null works portably. (In fact, this is even
  recommended in favor of -q for portability by GNU grep's man page.)
  
  This needs to be changed in virt-manager's src/virtManager/console.py
  (by adding a new patch) and libvirt's debian/patches/Autodetect-if-the-
  remote-nc-command-supports-the-q-o.patch (and the updated patch
  reapplied to src/remote/remote_driver.c).
  
  BEFORE:
  grep -q \"requires an argument\"
  AFTER:
  grep \"requires an argument\" >/dev/null

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to libvirt in Ubuntu.
https://bugs.launchpad.net/bugs/792985

Title:
  virt-manager fails if target system has no grep -q