[Bug 667817] Re: euca-bundle-vol should create target filesystem same as source

[ray charly]

Hi,
First sorry for my poor English.
yesterday i tried to find an approach to solve the problem with "hard coded ext3 filesystem" in euca2ool/__init__.py.
My first reflexion was to write a function  that get Informations about the filesystem of the Instance then Overrides the "global hard coded" variable in Euca2ools/__init__.py   ( NEW_FSTAB, OLD_FSTAB and MAKEFS_CMD ) 
So this function could be call in  def make_fs(self, image_path ) to Update the filesytem type. 
Even i think that ALLOWED_FS_TYPES = ['ext2', 'ext3', 'xfs', 'jfs', 'reiserfs'] should containt an "ext4" Entry.

But after reading this post  https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/665235/comments/4   about /dev/sda1
i'm not sure anymore, that it is a good approach to solve it, since the Hard drive names are not the same on all Systems (/dev/sdax or /dev/vsda or /dev/sdh ??????)

I wrote a small "stand alone" Test file ( Just with the "Hard coded
variables" and an update function) to illustrate what i mean.

Is it  the right way to look for a solution to this problem?
The code looks a bit curious, since i'm not a Python Programmer.

Thanks

Raymdt



** Attachment added: "test.py"
   https://bugs.launchpad.net/ubuntu/+source/euca2ools/+bug/667817/+attachment/1786915/+files/test.py

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to euca2ools in ubuntu.
https://bugs.launchpad.net/bugs/667817

Title:
  euca-bundle-vol should create target filesystem same as source