[Bug 722133] [NEW] ntpdate script doesn't load configuration file

[Tomas Bosak]

Public bug reported:

Binary package hint: ntpdate

ntpdate script (located in /etc/network/if-up.d/ntpdate) doesn't load
configuration from file (located in /etc/default/ntpdate).

1) OS: Ubuntu 11.04 (natty)
2) Package version: 1:4.2.6.p2+dfsg-1ubuntu4 and previous versions
3) Load configuration file
4) Configuration file isn't loaded

Solution:
Add these lines to script (/etc/network/if-up.d/ntpdate):

if [ -r /etc/default/ntpdate ]; then
        . /etc/default/ntpdate
        OPTS="${OPTS} ${NTPOPTIONS} ${NTPSERVERS}"
fi

Complete script:

#!/bin/sh

set -e

PATH=/sbin:/bin:/usr/sbin:/usr/bin

# This is a heuristic:  The idea is that if a static interface is brought
# up, that is a major event, and we can put in some extra effort to fix
# the system time.  Feel free to change this, especially if you regularly
# bring up new network interfaces.
if [ "$METHOD" = static ]; then
        OPTS="-b"
fi

if [ "$METHOD" = loopback ]; then
        exit 0
fi

# Check whether ntpdate was removed but not purged; it's useless to wait for
# it in that case.
if [ ! -x /usr/sbin/ntpdate-debian ] && [ -d /usr/sbin ]; then
        exit 0
fi

if [ -r /etc/default/ntpdate ]; then
        . /etc/default/ntpdate
        OPTS="${OPTS} ${NTPOPTIONS} ${NTPSERVERS}"
fi

(

# This is for the case that /usr will be mounted later.
if [ -r /lib/udev/hotplug.functions ]; then
        . /lib/udev/hotplug.functions
        wait_for_file /usr/sbin/ntpdate-debian
fi

LOCKFILE=/var/lock/ntpdate-ifup

# Avoid running more than one at a time
if [ -x /usr/bin/lockfile-create ]; then
        lockfile-create $LOCKFILE
        lockfile-touch $LOCKFILE &
        LOCKTOUCHPID="$!"
fi

invoke-rc.d --quiet ntp stop >/dev/null 2>&1 || true

/usr/sbin/ntpdate-debian -s $OPTS 2>/dev/null || :

invoke-rc.d --quiet ntp start >/dev/null 2>&1 || true

if [ -x /usr/bin/lockfile-create ] ; then
        kill $LOCKTOUCHPID
        lockfile-remove $LOCKFILE
fi

) &

** Affects: ntp (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to ntp in ubuntu.
https://bugs.launchpad.net/bugs/722133

Title:
  ntpdate script doesn't load configuration file