[Bug 908908] [NEW] uninitialized variable in wbinfo_group.pl causes false authentication results

[b1]

Public bug reported:

I am using squid version 2.7.STABLE7 with users authenticating via an
ActiveDirectory (AD). I am using the wbinfo_group.pl helper script for
checking group memberships. After a while internet access is denied at
random for some users. In the squid log I see

Use of uninitialized value in concatenation (.) or string at
/usr/lib/squid/wbinfo_group.pl line 67, <STDIN> line 1.

this message repeats from time to time, with "line 1" increasing. As
described in http://www.linuxquestions.org/questions/linux-server-73
/squid-ntlm-authentication-only-first-logon-is-authenticated-723587/ I
explicitly set the variable $ans. After that I get some errors about

Character in 'c' format wrapped in pack at
/usr/lib/squid/wbinfo_group.pl line 92, <STDIN> line 1.

So I changed the function call

pack("c",hex($1))

to

pack("C",hex($1))

everywhere in the script. Since then everything is running smoothly. No
more random errors. I have attached a diff file with the changes.

I am running Ubuntu 10.04.3 LTS
squid  version 2.7.STABLE7

If you need any more information I am happy to provide it.

Thanks for your efforts

B. Brandt

** Affects: squid (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to squid in Ubuntu.
https://bugs.launchpad.net/bugs/908908

Title:
  uninitialized variable in wbinfo_group.pl causes false authentication
  results

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid/+bug/908908/+subscriptions