[Bug 661024] Re: etckeeper fail to work when installed during installation

[Thierry Carrez]

Analysis:
In the case of an early install, the logic to determine USER in /etc/etckeeper/commit.d/50vcs-commit fails to yield a valid USER, so EMAIL is not set when bzr commit is called (no name being stored in bzr whoami, this fails)

Solution would be to do something like:

ORIG_USER=$USER
USER=
...
  if [ -n "$USER" ]; then
      export EMAIL="$USER <$USER@$hostname>"
  else
      bzr whoami || export EMAIL="$ORIG_USER <$ORIG_USER@$hostname>"
  fi

This avoids setting bzr whoami artificially at install-time, still
prefers stored creds if any are present, but defaulting to something
valid rather than failing in the corner case of this bug.

Reducing priority since this doesn't affect post-install installations
of etckeeper. i'll fix this if nobody beats me to it.

** Changed in: etckeeper (Ubuntu)
   Importance: High => Medium

** Changed in: etckeeper (Ubuntu)
       Status: Confirmed => Triaged

-- 
etckeeper fail to work when installed during installation
https://bugs.launchpad.net/bugs/661024
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to etckeeper in ubuntu.