[Bug 372358] Re: Please merge openvpn 2.1~rc15-1 (main) from Debian unstable (main)

[Thierry Carrez]

Hey Andres, thank you for your work on this !

About testing:
Did you doublecheck that you can still start the password-protected VPNs manually (after boot) using "sudo service openvpn start <vpnname>" and entering the right password ?

About the changelog entries:
 * Do not use start-stop-daemon and use < /dev/null to avoid blocking boot
    In fact you're now using start-stop-daemon so it should just read "Use < /dev/null to avoid blocking boot"
 * Fix VPNs always reported started [ OK ]
    This was a fix to our "per-VPN" patch so mentioning "show per-VPN result messages" is sufficient

A few more nitpicking comments:
 * There is some (unneeded) spacing difference in the first three lines of:
-        --pidfile /var/run/openvpn.$NAME.pid \
-        --exec $DAEMON -- $OPTARGS --writepid /var/run/openvpn.$NAME.pid \
-        $DAEMONARG $STATUSARG --cd $CONFIG_DIR \
-        --config $CONFIG_DIR/$NAME.conf || STATUS=1
+	--pidfile /var/run/openvpn.$NAME.pid \
+	--exec $DAEMON -- $OPTARGS --writepid /var/run/openvpn.$NAME.pid \
+	$DAEMONARG $STATUSARG --cd $CONFIG_DIR \
+	--config $CONFIG_DIR/$NAME.conf $script_security < /dev/null || STATUS=1
It could probably be fixed so that the diff doesn't show the first three lines as different, something like:
-        --config $CONFIG_DIR/$NAME.conf || STATUS=1
+        --config $CONFIG_DIR/$NAME.conf $script_security < /dev/null || STATUS=1

 * I would just drop the lsb-base (>= 3.2-14) dependency in
debian/control to match what debian does (we have 3.2-20ubuntu4 in
karmic anyway)

In all cases I'm not a core-dev yet, so someone else still needs to
comment/sponsor this :)

-- 
Please merge openvpn 2.1~rc15-1 (main) from Debian unstable (main)
https://bugs.launchpad.net/bugs/372358
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to openvpn in ubuntu.