[Bug 277492] Re: lwinet crashes when joining a windows domain with likewise

[Gerald Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Theirry,

I'll review your comments today and get back to you soon.


jerry


Thierry Carrez wrote:
> There might be a case where get_sorted_dc_list can be called with null arguments, resulting in the SIGSEGV.
> In samba/source/libads/ldap.c (function ads_find_dc) :
> 
> -----------------------------------------------------------
> if ( !got_realm && !lp_disable_netbios() ) {
>   c_realm = ads->server.workgroup;
>   if (!c_realm || !*c_realm) {
>     if ( use_own_domain )
>       c_realm = lp_workgroup();
>   }
>   if ( !c_realm || !*c_realm ) {
>     DEBUG(0,("ads_find_dc: no realm or workgroup!  Don't know what to do\n"));
>     return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */
>   }
> }
> realm = c_realm;
> [...]
> status = get_sorted_dc_list(realm, sitename, &ip_list, &count, got_realm);
> -----------------------------------------------------------
> 
> The catch for the case *c_realm=null is inside the "if ( !got_realm &&
> !lp_disable_netbios() )" test so if *c_realm=null, got_realm is false
> and lp_disable_netbios() is true, you get SIGSEGV down the line...
> 


- --
=====================================================================
Samba                                    ------- http://www.samba.org
Likewise Software          ---------  http://www.likewisesoftware.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI61u4IR7qMdg1EfYRAgjZAKDzZDs599952Nd9YK5lEr/J8MK+nwCgut5b
7yYy84BlnfkZ9RGOSwAuvYo=
=D1QT
-----END PGP SIGNATURE-----

-- 
lwinet crashes when joining a windows domain with likewise
https://bugs.launchpad.net/bugs/277492
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to likewise-open in ubuntu.