[Bug 284572] Re: smbclient crashed with SIGSEGV in strlen()

tomek.bury tomek.bury at gmail.com
Sun Nov 16 19:13:58 GMT 2008


I've just noticed the patch is reversed. It should be:

$ diff -u samba-3.2.3/source/libsmb/clilist.c.orig samba-3.2.3/source/libsmb/clilist.c
--- samba-3.2.3/source/libsmb/clilist.c.orig	2008-08-27 12:23:20.000000000 +0100
+++ samba-3.2.3/source/libsmb/clilist.c	2008-11-16 18:22:03.399036086 +0000
@@ -417,7 +417,7 @@
 		}
 
 		SAFE_FREE(mask);
-		if (ff_searchcount > 0) {
+		if (ff_searchcount > 0 && finfo.name) {
 			mask = SMB_STRDUP(finfo.name);
 		} else {
 			mask = SMB_STRDUP("");

Cheers
Tomek

** Attachment added: "clilist.c patch"
   http://launchpadlibrarian.net/19700236/patch.txt

-- 
smbclient crashed with SIGSEGV in strlen()
https://bugs.launchpad.net/bugs/284572
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to samba in ubuntu.



More information about the Ubuntu-server-bugs mailing list