[Merge] ~slyon/network-manager:fix-deprecated-autopkgtests into network-manager:ubuntu/master

[Lukas Märdian]

The proposal to merge ~slyon/network-manager:fix-deprecated-autopkgtests into network-manager:ubuntu/master has been updated.

Description changed to:

Refresh NetworkManager autopkgtests. Avoiding deprecated function calls and deprecated tools (such as ISC dhclient).

This is to fix the confusing test logs/output, like "FAIL ok" or race-conditions with the "loopback" interface.

PPA build:
https://launchpad.net/~slyon/+archive/ubuntu/testing/+packages?field.name_filter=network-manager&field.status_filter=published&field.series_filter=plucky

PPA tests (still pending):
$ ppa tests ppa:slyon/testing -p network-manager -r plucky -L
[...]
* Results:
  - network-manager/1.50.0-1ubuntu3~ppa2



Fix "FAIL ok" and "DeprecationWarning":
"""
182s test_auto_ip4 (__main__.ColdplugEthernet.test_auto_ip4)
188s ethernet: auto-connection, IPv4 ... /tmp/autopkgtest.Iy4pDw/build.2Ow/src/debian/tests/nm.py:276: DeprecationWarning: NM.Client.deactivate_connection is deprecated
188s   self.nmclient.deactivate_connection(active_conn)
188s FAIL
188s ok
"""

Fix permission warnings:
"""
test_create_connection_via_netplan_and_change_it_via_nmcli (__main__.TestNetplan.test_create_connection_via_netplan_and_change_it_via_nmcli)
Create a connection via netplan generate and change it via nmcli. ...
** (process:2631): WARNING **: 15:43:50.908: Permissions for /etc/netplan/10-test.yaml are too open. Netplan configuration should NOT be accessible by others.
ok
"""

Fix unrelated dhclient output:
"""
 98s test_open_b_ip6_dhcp (__main__.T.test_open_b_ip6_dhcp)
109s Open network, 802.11b, IPv6 with DHCP ... Killed old client process
110s ok
"""

Fix Policykit integration:
"""
1188s Error org.freedesktop.URfkill.Daemon.Error.General: failed to check authorisation: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.PolicyKit1 was not provided by any .service files
1189s autopkgtest [22:58:46]: test urfkill-integration: -----------------------]
1189s urfkill-integration  FAIL non-zero exit status 1
"""

For more details, see:
https://code.launchpad.net/~slyon/network-manager/+git/network-manager/+merge/479905
-- 
Your team Network-manager is requested to review the proposed merge of ~slyon/network-manager:fix-deprecated-autopkgtests into network-manager:ubuntu/master.