[Merge] ~nteodosio/update-manager:b-proerror into update-manager:ubuntu/bionic

Sebastien Bacher mp+469197 at code.launchpad.net
Tue Sep 10 08:51:30 UTC 2024


Review: Needs Information

In fact could you check the linter? The CI is showing an error

:: FAIL: test_pyflakes_clean (__main__.TestPyflakesClean)
:: ----------------------------------------------------------------------
:: Traceback (most recent call last):
::   File "./tests/test_pyflakes.py", line 56, in test_pyflakes_clean
::     self.assertEqual(0, len(filtered_contents))
:: AssertionError: 0 != 8
::
:: ----------------------------------------------------------------------
:: Ran 1 test in 0.322s
::
:: FAILED (failures=1)
:: ../UpdateManager/Dialogs.py:39: 'subprocess' imported but unused
:: ../tests/test_backend_error.py:8: 'gettext.gettext as _' imported but unused
:: ../tests/test_backend_error.py:11: 'UpdateManager.Dialogs.NoUpdatesDialog' imported but unused
:: ../tests/test_backend_error.py:12: 'UpdateManager.UpdateManager.UpdateManager' imported but unused
:: ../tests/test_backend_error.py:13: 'UpdateManager.UpdatesAvailable.UpdatesAvailable' imported but unused
:: ../tests/test_update_error.py:5: 'mock' imported but unused
:: ../tests/test_update_error.py:13: 'UpdateManager.backend.InstallBackend' imported but unused
:: ../tests/test_update_error.py:13: 'UpdateManager.backend.get_backend' imported but unused
Job 'linter' for bionic/amd64 failed with exit status 1.

is that an issue in the CI job a problem that we will hit if we upload?
-- 
https://code.launchpad.net/~nteodosio/update-manager/+git/update-manager/+merge/469197
Your team Ubuntu Core Development Team is subscribed to branch update-manager:ubuntu/bionic.




More information about the Ubuntu-reviews mailing list