[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:add-buildinfo-file into livecd-rootfs:ubuntu/master

[Cristovao Cordeiro]

Review: Needs Information



Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index 695344e..264418f 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -973,6 +973,7 @@ configure_oci() {
>      # Inject a build stamp into the image
>      mkdir -p ${chroot}/etc/cloud

Thanks for the changes.

In previous commits you were moving the code block from `functions` to `auto/build`, but now you have both.

I guess the redundancy doesn't hurt, but I'm wondering what the expected sequence of events is...

 - is auto/build always supposed to run?
 - what about "functions"? cause if "function" doesn't run, `mkdir` won't run, and your code block in "auto/build" will fail due to the missing folder.
 - and if both scripts run, why duplicate the writing of the file?

>      cat > ${chroot}/etc/cloud/build.info << EOF
> +build_name: $PROJECT:${SUBPROJECT:}
>  serial: $serial
>  EOF
>  


-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/461713
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.