[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:add-buildinfo-file into livecd-rootfs:ubuntu/master

Cristovao Cordeiro mp+461713 at code.launchpad.net
Thu Mar 7 13:35:36 UTC 2024


Review: Needs Information



Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 9911708..9a32a40 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -430,9 +430,20 @@ serial: $BUILDSTAMP
>  EOF
>  		fi
>  
> +		if [ "$PROJECT:${SUBPROJECT:-}" = ubuntu-base:minimized ]; then
> +			cat > chroot/etc/$PROJECT/build.info << EOF
> +build_name: $PROJECT:${SUBPROJECT:}
> +serial: $BUILDSTAMP
> +EOF
> +		fi
> +
>  		if [ "$PROJECT" = "ubuntu-oci" ]; then
>  			if [ -n "$BUILDSTAMP" ]; then
>  				configure_oci chroot "$BUILDSTAMP"
> +				cat > chroot/etc/$PROJECT/build.info << EOF
> +build_name: $PROJECT
> +serial: $BUILDSTAMP
> +EOF
>  			else
>  				echo "The \$BUILDSTAMP variable is empty"
>  				exit 1

Thanks for the change. From your tests, when would this happen? I'm just trying to understand if, upon merging this, all subsequent builds will start failing because the variable isn't available on this scope...



-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/461713
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list