[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:add-buildinfo-file into livecd-rootfs:ubuntu/master

Philip Roche mp+461713 at code.launchpad.net
Tue Mar 5 14:39:44 UTC 2024


Review: Needs Information



Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 9911708..b6a5e0c 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -430,10 +430,37 @@ serial: $BUILDSTAMP
>  EOF
>  		fi
>  
> +		if [ "$PROJECT:${SUBPROJECT:-}" = ubuntu-base:minimized ]; then
> +			BUILD_NAME=minimal
> +			cat > chroot/etc/base/build.info << EOF

I don't feel we need this logic. We can just write to ` chroot/etc/$PROJECT/build.info` and `build_name:` can be `$PROJECT:${SUBPROJECT:}`

> +build_name: $BUILD_NAME
> +serial: $BUILDSTAMP
> +EOF
> +		fi
> +
>  		if [ "$PROJECT" = "ubuntu-oci" ]; then
>  			if [ -n "$BUILDSTAMP" ]; then
>  				configure_oci chroot "$BUILDSTAMP"
> +				if [ "${SUBPROJECT:-}" = minimized ]; then
> +					BUILD_NAME=minimal
> +				else
> +					BUILD_NAME=base
> +				fi
> +				cat > chroot/etc/oci/build.info << EOF
> +build_name: $BUILD_NAME
> +serial: $BUILDSTAMP
> +EOF
> +				fi
>  			else
> +				if [ "${SUBPROJECT:-}" = minimized ]; then
> +					BUILD_NAME=minimal
> +				else
> +					BUILD_NAME=base
> +				fi
> +					cat > chroot/etc/oci/build.info << EOF
> +build_name: $BUILD_NAME
> +EOF

+1 on including the serial/$BUILDSTAMP

> +				fi
>  				echo "The \$BUILDSTAMP variable is empty"
>  				exit 1
>  			fi


-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/461713
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list