[Merge] ~cpete/ubuntu-dev-tools:update-python-launchpadlib into ubuntu-dev-tools:main

[Andreas Hasenack]

Review: Needs Information



Diff comments:

> diff --git a/debian/changelog b/debian/changelog
> index 114432a..437e6c8 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,10 @@
> +ubuntu-dev-tools (0.202) UNRELEASED; urgency=medium

UNRELEASED is clearly wrong, but I can of course replace that with "noble" before uploading. But let me ask this: I see that this package is in sync with debian, so what is the usual release flow for this? It's a package with tools for "ubuntu devs", but it's a sync with debian?

Also, what about the repository at https://git.launchpad.net/ubuntu-dev-tools which is marked as the upstream for this? Should that be updated first?

> +
> +  * Replace Depends on python3-launchpadlib with Depends on
> +    python3-launchpadlib-desktop (LP: #2049217)
> +
> + -- Chris Peterson <chris.peterson at canonical.com>  Mon, 26 Feb 2024 15:36:48 -0800
> +
>  ubuntu-dev-tools (0.201) unstable; urgency=medium
>  
>    * running-autopkgtests: fix packaging to make the script available
> diff --git a/ubuntutools/test/test_requestsync.py b/ubuntutools/test/test_requestsync.py
> new file mode 100644
> index 0000000..09fa3c4
> --- /dev/null
> +++ b/ubuntutools/test/test_requestsync.py
> @@ -0,0 +1,36 @@
> +# Copyright (C) 2024 Canonical Ltd.
> +# Author: Chris Peterson <chris.peterson at canonical.com>
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU Affero General Public License as
> +# published by the Free Software Foundation, either version 3 of the
> +# License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU Affero General Public License for more details.
> +#
> +# You should have received a copy of the GNU Affero General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.

debian/copyright states that files under ubuntutools/test/* are ISC licensed, but this header uses AGPL v3+. The only other test script in that directory that is AGPLv3 is test_running_autopkgtests.py, also added by Chris Peterson. I'm not sure what to do with this :/

> +
> +import unittest
> +
> +
> +# Binary Tests
> +class BinaryTests(unittest.TestCase):
> +
> +    # The requestsync binary has the option of using the launchpad api
> +    # to log in but requires python3-keyring in addition to
> +    # python3-launchpadlib. Testing the integrated login functionality
> +    # automatically isn't very feasbile, but we can at least write a smoke
> +    # test to make sure the required packages are installed.
> +    # See LP: #2049217
> +    def test_keyring_installed(self):
> +        """Smoke test for required lp api dependencies"""
> +        try:
> +            import keyring  # noqa: F401
> +        except ModuleNotFoundError:
> +            raise ModuleNotFoundError(
> +                "package python3-keyring is not installed"
> +            )


-- 
https://code.launchpad.net/~cpete/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/461309
Your team Ubuntu Development Team is subscribed to branch ubuntu-dev-tools:main.