[Merge] ~enr0n/ubuntu-release-upgrader:drop-unused-quirks into ubuntu-release-upgrader:ubuntu/main

[Julian Andres Klode]

Review: Approve

Ship it (one comment about the pci helper).

Diff comments:

> diff --git a/DistUpgrade/DistUpgradeQuirks.py b/DistUpgrade/DistUpgradeQuirks.py
> index 166e64d..2e78137 100644
> --- a/DistUpgrade/DistUpgradeQuirks.py
> +++ b/DistUpgrade/DistUpgradeQuirks.py
> @@ -197,19 +187,6 @@ class DistUpgradeQuirks(object):
>          self._install_linux_metapackage()
>  
>      # helpers
> -    def _get_pci_ids(self):

I think this helper may be worthwhile keeping in case we need it again, but also we probably should just do it right then and walk sysfs, so idk

> -        """ return a set of pci ids of the system (using lspci -n) """
> -        lspci = set()
> -        try:
> -            p = subprocess.Popen(["lspci", "-n"], stdout=subprocess.PIPE,
> -                                 universal_newlines=True)
> -        except OSError:
> -            return lspci
> -        for line in p.communicate()[0].split("\n"):
> -            if line:
> -                lspci.add(line.split()[2])
> -        return lspci
> -
>      def _get_from_and_to_version(self):
>          di = distro_info.UbuntuDistroInfo()
>          try:


-- 
https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/467986
Your team Ubuntu Core Development Team is subscribed to branch ubuntu-release-upgrader:ubuntu/main.