[Merge] ~utkarsh/+git/unminimize:unminimize-postinst into ~utkarsh/+git/unminimize:master

Michael Hudson-Doyle mp+467548 at code.launchpad.net
Mon Jun 17 01:53:48 UTC 2024


So this looks very much like it will work as intended in the expected situation. The fear of course is that if run in some unexpected situation it might nuke some unrelated script, not the one livecd-rootfs generated. It's an unlikely scenario but not impossible. I wonder if it makes sense to grep for "This system has been minimized by removing packages" or some other distinctive string before removing it? Or is that being overly cautious? Wdyt?

Diff comments:

> diff --git a/debian/unminimize.postinst b/debian/unminimize.postinst
> new file mode 100644
> index 0000000..5c3120d
> --- /dev/null
> +++ b/debian/unminimize.postinst
> @@ -0,0 +1,23 @@
> +#!/bin/sh
> +
> +set -e
> +
> +case "$1" in
> +    configure)
> +        if [ -f "/usr/local/sbin/unminimize" ]; then
> +          rm -f /usr/local/sbin/unminimize

Very minor obviously but the indentation is inconsistent here.

> +        fi
> +    ;;
> +
> +    upgrade|abort-upgrade|abort-remove|abort-deconfigure)
> +    ;;
> +
> +    *)
> +        echo "postinst called with unknown argument \`$1'" >&2
> +        exit 1
> +    ;;
> +esac
> +
> +#DEBHELPER#
> +
> +exit 0


-- 
https://code.launchpad.net/~utkarsh/+git/unminimize/+merge/467548
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~utkarsh/+git/unminimize:unminimize-postinst into ~utkarsh/+git/unminimize:master.




More information about the Ubuntu-reviews mailing list