[Merge] ~jefferyto/ubuntu/+source/initramfs-tools:ubuntu-core-dev-fix-resume-device-type-check into ~ubuntu-core-dev/ubuntu/+source/initramfs-tools:ubuntu/devel
Jeffery To
mp+468643 at code.launchpad.net
Thu Jul 4 17:54:38 UTC 2024
I prefer neither option because if statements should not have side effects, in this case setting a variable. (Sometimes this is unavoidable with shell scripts, but it should be avoided when possible.) Both options are also less readable than my original code.
Having examined the code for resolve_device, I am convinced it only prints output if it is successful. Is there any condition in resolve_device where it will print output as an error?
--
https://code.launchpad.net/~jefferyto/ubuntu/+source/initramfs-tools/+git/initramfs-tools/+merge/468643
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/initramfs-tools:ubuntu/devel.
More information about the Ubuntu-reviews
mailing list