[Merge] ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel-core-dump-handler into ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel

[Simon Chopin]

Review: Needs Fixing

LGTM except for the circular deps thing, which should really not be happening.

Diff comments:

> diff --git a/debian/apport-core-dump-handler.install b/debian/apport-core-dump-handler.install
> new file mode 100644
> index 0000000..124c9fd
> --- /dev/null
> +++ b/debian/apport-core-dump-handler.install
> @@ -0,0 +1,2 @@
> +debian/tmp/etc/init.d/apport

thought: I think we could scrap that file altogether in a future update, couldn't we?

> +usr/lib/systemd/system/apport.service
> diff --git a/debian/control b/debian/control
> index 630358f..531464a 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -96,6 +95,22 @@ Description: Python 3 library for Apport crash report handling
>    * Various frontend utility functions.
>    * Python hook to generate crash reports when Python scripts fail.
>  
> +Package: apport-core-dump-handler
> +Architecture: all
> +Depends: apport (>= 2.27.0-0ubuntu7~), ${misc:Depends}

issue: Could we avoid the circular dependencies?

I *think* it's OK right now as I don't think apport has a postinst, but 1/ that's just a guess and 2/ that might not hold in the future.

> +Breaks: apport (<< 2.27.0-0ubuntu7~)
> +Replaces: apport (<< 2.27.0-0ubuntu7~), core-dump-handler
> +Conflicts: core-dump-handler
> +Provides: core-dump-handler
> +Pre-Depends: ${misc:Pre-Depends}
> +Description: Kernel core dump handler for Apport
> + apport automatically collects data from crashed processes and
> + compiles a problem report in /var/crash/. This utilizes the crashdump
> + helper hook provided by the Ubuntu kernel.
> + .
> + This package provides the service that configures the kernel (via
> + /proc/sys/kernel/core_pattern) to forward the crash dumps to apport.
> +
>  Package: apport-retrace
>  Section: devel
>  Architecture: all
> @@ -205,7 +220,7 @@ Depends:
>   python3,
>   python3-apport (>= ${source:Version}),
>   whoopsie (>= 0.2.77),
> - ${misc:Depends},
> + ${misc:Depends}

nitpick: could we avoid this kind of noise please?

Also, trailing commas are good!

>  Description: tools for automatically reporting Apport crash reports
>   apport automatically collects data from crashed processes and
>   compiles a problem report in /var/crash/. This utilizes the crashdump


-- 
https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/apport/+git/apport/+merge/458513
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel.