[Merge] ~simpoir/livecd-rootfs/+git/livecd-rootfs:cpc4873_toomany-part2 into livecd-rootfs:ubuntu/master

Simon Poirier mp+471770 at code.launchpad.net
Wed Aug 21 23:11:28 UTC 2024


Simon Poirier has proposed merging ~simpoir/livecd-rootfs/+git/livecd-rootfs:cpc4873_toomany-part2 into livecd-rootfs:ubuntu/master.

Commit message:
disk-image-uefi: Fix regression with partition sizing on arm

The sgdisk arguments for arm got mistakenly reordered, with the second
partition starting at offset 0.



Requested reviews:
  Canonical Foundations Team (canonical-foundations)

For more details, see:
https://code.launchpad.net/~simpoir/livecd-rootfs/+git/livecd-rootfs/+merge/471770

Alternative solution could have been to switch part15 to using relative offsets instead of absolute sizing.


Tested with autopkgtest on amd64 and triggered livebuilds with arm64 on launchpad for good measure.

arm64 build https://launchpad.net/~cloudware/+livefs/ubuntu/oracular/cpc-development/+build/672579
amd64 build https://launchpad.net/~cloudware/+livefs/ubuntu/oracular/cpc-development/+build/672578

Both build, both boot, new partitions look similar (minus the 4M bios boot part on amd64 and the different partition alignments):
Number  Start (sector)    End (sector)  Size       Code  Name
   1         2324480         7339998   2.4 GiB     8300
  13            2048         2097152   1023.0 MiB  EA00
  14         2099200         2107391   4.0 MiB     EF02
  15         2107392         2324479   106.0 MiB   EF00


Number  Start (sector)    End (sector)  Size       Code  Name
   1         2099200         7339998   2.5 GiB     8300  
  13          206848         2097152   923.0 MiB   EA00  
  15            2048          204800   99.0 MiB    EF00  
-- 
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 706 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20240821/584ff0b2/attachment.diff>


More information about the Ubuntu-reviews mailing list