[Merge] ~philroche/livecd-rootfs/+git/livecd-rootfs:feature/re-enable-noble-hyperv-desktop-builds into livecd-rootfs:ubuntu/master

[Philip Roche]

Philip Roche has proposed merging ~philroche/livecd-rootfs/+git/livecd-rootfs:feature/re-enable-noble-hyperv-desktop-builds into livecd-rootfs:ubuntu/master.

Commit message:
fix(HyperV desktop): Re-enable ability to build HyperV desktop images (LP: #2064280)

We have not built Hyperv desktop images since Jammy and with the re-introduction of HyperV for Noble we have encountered build issues caused by refactoring and removals of code assumed to be redundant but the HyperV desktop images were actually using these code paths.

In bbedffe6 we split the building of cloud images and non cloud to using an ddisk-image-uefi.binary and disk-image-uefi-non-cloud.binary respectively. In e38264ca there was a change which meant that any attempt to build hyperv images would result in incorrect disk size and incorrect disk label.

This has been fixed by ensuring that the ubuntu:desktop-preinstalled $PROJECT:$SUBPROJECT matches and sets the correct disk size and correct disk label.

A change in 76d79466 changed the logic of how the image size for amd64 images were being set. This overrode the sizes set for the desktop images incorrectly.

This MP ensures that hyperv desktop images can now be built and successfully launched with hyperv manager.



Requested reviews:
  Canonical Foundations Team (canonical-foundations)
Related bugs:
  Bug #2064280 in livecd-rootfs (Ubuntu): "Hyperv desktop images no longer building in Noble"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2064280

For more details, see:
https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-rootfs/+merge/465288
-- 
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4100 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20240430/44a1173b/attachment.diff>