[Merge] ~tchavadar/livecd-rootfs:install-image-definitions-deb-option into livecd-rootfs:ubuntu/master

Talha Can Havadar mp+464755 at code.launchpad.net
Thu Apr 25 08:09:53 UTC 2024


This way to make override for these variables made possible in mid of 2023, please see commits https://git.launchpad.net/livecd-rootfs/commit/?id=262d0f3170de389f968286558c552d48d916fc2a and https://git.launchpad.net/livecd-rootfs/commit/?id=9390fdaa0a79a373b69cab3dca046ad4a48bc01e

So I wanted to keep the same way of working here by making new variables also overridable which can be done afterwards with another MP to launchpad-buildd repo.

Our idea behind using ubuntu-images as debian repo is to keep livecd-rootfs same as upstream, we sill just push the enablement changes for the new platform to upstream in a merge proposal and create our own private ubuntu-images package so that when the platform enablement in livecd-rootfs is upstreamed we dont have much to maintain just image definition files.

There is also this use case, where we upstreamed everything in livecd-rootfs and also in ubuntu-images git repo. But we might still need something private for early image releases, where things is not ready to be public, in those cases we could use our private ubuntu-images repo without needing a change in upstream livecd-rootfs, easy to maintain, less complex, just a yaml file and maybe some hooks here in there. 

But I would like to hear more about the recipe CPC team uses.

What do you think about making things overridable, what is the disadvantage of having them like that? Should I also revert the others as well? I didnt want to cut a functionality which was already given to folks months ago



-- 
https://code.launchpad.net/~tchavadar/livecd-rootfs/+git/livecd-rootfs/+merge/464755
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list