[Merge] ~dbungert/livecd-rootfs:lp-2063192-more-drives into livecd-rootfs:ubuntu/master

Nick Rosbrook mp+464842 at code.launchpad.net
Tue Apr 23 15:38:16 UTC 2024


It might make sense to use `ExecStopPost=`[1] instead of `ExecStop=` so that the cleanup happens on failure too. Otherwise, this looks like the correct service definition for replicating /usr/lib/udisks2/udisks2-inhibit.

[1] https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#ExecStopPost=
-- 
https://code.launchpad.net/~dbungert/livecd-rootfs/+git/livecd-rootfs/+merge/464842
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list