[Merge] ~tchavadar/livecd-rootfs:use-ubuntu-images-as-package into livecd-rootfs:ubuntu/master

Steve Langasek mp+464550 at code.launchpad.net
Fri Apr 19 18:50:13 UTC 2024


Review: Disapprove

I think we have an impedance mismatch here.  You want to use ubuntu-images as a package because it gives you a way to deliver it in a private ppa.  We want to NOT use it as a package because that causes an unnecessary indirection in delivering it to the Ubuntu archive for official image builds.

I would suggest that you consider making this configurable via livefs build meta data so that we can have it both ways.  An "ubuntu_images_src" key Mount point to a private git repo with credentials for accessing it, or could point to a package name that could be installed dynamically in the livecd-rootfs environment. 

Another option would be to look at what the CPC team does, with their private builds of cloud images by merging livecd-rootfs from upstream with their overlay code using a package recipe; a small bit of glue code in the base package would be enough to let you pull your ubuntu-images definitions locally. 

In any case, this MP is very large and includes changes that I think need to be considered independently (the question of falling back to ubuntu-images for unknown architecture is independent of whether we want ubuntu-images as a package), so I am rejecting this MP as-is.
-- 
https://code.launchpad.net/~tchavadar/livecd-rootfs/+git/livecd-rootfs/+merge/464550
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list