[Merge] ~nteodosio/software-properties:deb822-apt-add into software-properties:ubuntu/master

Nick Rosbrook mp+464417 at code.launchpad.net
Tue Apr 16 17:23:47 UTC 2024


Review: Needs Fixing

I have two thoughts on this.

First is that I am not positive that by enabling deb822=True, we won't introduce regressions in other parts of the code that are not deb822-aware yet. For that reason, it *might* be safer to re-init sources list with deb822=True in show_list() instead of using self.sourceslist. On the other hand, @juliank did a lot of work on python-apt since I first started writing deb822 support for things, so my concern might be unnecessary.

Second is that current output is a bit awkward with deb822 sources. For example, if I have the default Ubuntu sources on Noble, then I get:

$ add-apt-repository --list
deb http://us.archive.ubuntu.com/ubuntu/ noble noble-updates noble-backports main restricted universe multiverse
deb http://security.ubuntu.com/ubuntu noble-security main restricted universe multiverse

which kind of look like classic .list entries, but are invalid because they specify multiple suites. The same would happen if we had a deb822 source with Types: deb deb-src, or multiple URIs.

If the desire here *is* to list out deb822 sources as classic .list entries, then we need logic to do handle what I described above. Otherwise, I would just leave the print(s), and add a newline between deb822 sources.

-- 
https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/464417
Your team Ubuntu Core Development Team is subscribed to branch software-properties:ubuntu/master.




More information about the Ubuntu-reviews mailing list