[Merge] ~philroche/livecd-rootfs/+git/livecd-rootfs:bugfix/lp-2061121-snap-preseed-latest into livecd-rootfs:ubuntu/mantic
John Chittum
mp+464199 at code.launchpad.net
Fri Apr 12 12:36:55 UTC 2024
Review: Needs Information
Hm, wait, we encode this in the server seeds
https://ubuntu-archive-team.ubuntu.com/seeds/ubuntu.jammy/server
as
* snap:lxd=5.0/stable/ubuntu-22.04 # Every Ubuntu server can host 100x containers
if i'm reading the code correctly, this _shouldn't_ be solving the issue for snaps in the seeds:
# Seed from the specified channel (e.g. core18 latest/stable)
# Or Channel endcoded in the snap name (e.g. lxd=4.0/stable/ubuntu-20.04)
# Or Ubuntu policy default channel latest/stable/ubuntu-$(release_ver)
local CHANNEL=${3:-}
if [ -z "$CHANNEL" ]; then
case $2 in
*=*)
CHANNEL=${2#*=}
;;
*)
CHANNEL="stable/ubuntu-$(release_ver)"
;;
esac
fi
also, wouldn't this end up affecting every other snap that doesn't have it encoded or a specific version passed in? so if you just request a pre_seed of $my_snap it'll go to `latest/stable/ubuntu-$(release_version)` which doesn't match the policy...
https://wiki.ubuntu.com/UbuntuSeededSnaps#Channel_availability
So it's special casing around lxd, which may break other things?
--
https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-rootfs/+merge/464199
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/mantic.
More information about the Ubuntu-reviews
mailing list