[Merge] ~nteodosio/software-properties:comment-flood into software-properties:ubuntu/master

Julian Andres Klode mp+463886 at code.launchpad.net
Thu Apr 11 08:19:07 UTC 2024


Review: Needs Fixing

Two things to sort out:

- The first line may be empty
- If we hide stuff should display [...]

I'd wager replacing newlines by spaces and picking a length to display would be easier avoids having to deal with empty lines at least, and can produce more details, something like:

source.comment.replace("\n", " ")[:80] + ("[...]" if len(source.comment) > 80 else "")


-- 
https://code.launchpad.net/~nteodosio/software-properties/+git/software-properties/+merge/463886
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~nteodosio/software-properties:comment-flood into software-properties:ubuntu/master.




More information about the Ubuntu-reviews mailing list