[Merge] ~dviererbe/ubuntu-seeds/+git/ubuntu:add-dotnet8-to-noble into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:noble

[Lukas Märdian]

Review: Needs Fixing

Plenty of inline comments! :)

I guess we can reduce it to just this:

 * dotnet8  # MIR (LP: #2060056)
 * aspnetcore-runtime-dbg-8.0
 * dotnet-runtime-dbg-8.0
 * dotnet-sdk-dbg-8.0


I wonder where the *-dbg-8.0 naming comes from? Would it be *-dbg, it could be caught by "Extra-Includes" automatically. But I guess it's fine to list those 3 packages here explicitly. Are the *-dbg-* packages really needed in main, though?

The original dotNET6 MIR review didn't mention them explicitly: "List of specific binary packages to be promoted to main: dotnet6 dotnet-host dotnet-hostfxr-6.0 dotnet-runtime-6.0 aspnetcore-runtime-6.0 dotnet-templates-6.0 dotnet-sdk-6.0 dotnet-targeting-pack-6.0 netstandard-targeting-pack-2.1 aspnetcore-targeting-pack-6.0 dotnet-apphost-pack-6.0"

IMO it should be fine either way. Keep or drop *-dbg-* as you like!

Diff comments:

> diff --git a/development b/development
> index c448b52..eadb445 100644
> --- a/development
> +++ b/development
> @@ -43,3 +43,19 @@ Additional supported languages
>   * golang
>   * rustc
>   * cargo
> +

After reducing all the unneeded lines, we can probably drop this empty line, too. It will be a much smaller dotNET8 block :)

> + * aspnetcore-runtime-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * aspnetcore-runtime-dbg-8.0

Note: This is not covered by Extra-Include, so it's fine to stay here.

> + * aspnetcore-targeting-pack-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-apphost-pack-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-host-8.0

dotnet8 -> dotnet-sdk-8.0 -> dotnet-hostfxr-8.0|dotnet-templates-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-hostfxr-8.0

dotnet8 -> dotnet-sdk-8.0 -> dotnet-runtime-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-runtime-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-runtime-dbg-8.0

Note: This is not covered by Extra-Include, so it's fine to stay here.

> + * dotnet-sdk-8.0

This is a dependency of bin:dotnet8, can be dropped from the seed.

> + * dotnet-sdk-dbg-8.0

Note: This is not covered by Extra-Include, so it's fine to stay here.

> + * dotnet-targeting-pack-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet-templates-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * dotnet8

Note: This is the core of what we want :) Please add a comment, referencing the MIR bug here.

> + * netstandard-targeting-pack-2.1-8.0

dotnet8 -> dotnet-sdk-8.0 "Depends" on this, should be dropped from the seed.

> + * Extra-Exclude: dotnet-sdk-8.0-source-built-artifacts

IIUC this is not pulled in by anything (reverse Depends or Recommends). So no need to exclude it. Furthermore, The "Extra-Exclude" wouldn't work here, as it can only drop things from "Extra-Include" (see "supported" seed). Please drop this line.

$ reverse-depends -r noble dotnet-sdk-8.0-source-built-artifacts

So it can just be demoted by an AA after src:dotnet8 got promoted.



-- 
https://code.launchpad.net/~dviererbe/ubuntu-seeds/+git/ubuntu/+merge/463930
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:noble.