[Merge] ~xnox/ubuntu-seeds:x13s into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:mantic
Steve Langasek
mp+452486 at code.launchpad.net
Sat Sep 30 01:34:58 UTC 2023
Review: Needs Fixing
Diff comments:
> diff --git a/canary-ship-live b/canary-ship-live
> index 925db6a..3f1b05b 100644
> --- a/canary-ship-live
> +++ b/canary-ship-live
I wouldn't bother changing the canary-ship-live seed, there is currently no canary build and I'm sure if and when we use it again we'll need to re-sync.
> @@ -75,14 +75,15 @@ install.
>
> * /^oem-.+-meta$/
> * linux-oem-22.04
> - * linux-generic-hwe-22.04
> + * linux-generic-hwe-22.04 [amd64]
> + * linux-laptop-23.10
>
> == nvidia ==
>
> - * /^nvidia-driver-535$/
> - * /^linux-modules-nvidia-535-generic-hwe-22.04$/
> - * /^linux-modules-nvidia-535-oem-22.04$/
> - * nvidia-prime
> + * /^nvidia-driver-535$/ [amd64]
> + * /^linux-modules-nvidia-535-generic-hwe-22.04$/ [amd64]
> + * /^linux-modules-nvidia-535-oem-22.04$/ [amd64]
> + * nvidia-prime [amd64]
>
> == Blacklist ==
>
> diff --git a/ship-live b/ship-live
> index b41d557..97238a5 100644
> --- a/ship-live
> +++ b/ship-live
> @@ -73,14 +73,15 @@ install.
>
> * /^oem-.+-meta$/
> * linux-oem-22.04
> - * linux-generic-hwe-22.04
> + * linux-generic-hwe-22.04 [amd64]
> + * linux-laptop-23.10
This is arm64-only, so I'd prefer to see it arch qualified in the seed (if for no other reason than that I think we need to get better about cleaning up seeds to not reference non-existent packages)
>
> == nvidia ==
>
> - * /^nvidia-driver-535$/
> - * /^linux-modules-nvidia-535-generic-hwe-22.04$/
> - * /^linux-modules-nvidia-535-oem-22.04$/
> - * nvidia-prime
> + * /^nvidia-driver-535$/ [amd64]
> + * /^linux-modules-nvidia-535-generic-hwe-22.04$/ [amd64]
> + * /^linux-modules-nvidia-535-oem-22.04$/ [amd64]
> + * nvidia-prime [amd64]
>
> == Blacklist ==
>
--
https://code.launchpad.net/~xnox/ubuntu-seeds/+git/ubuntu-seeds/+merge/452486
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:mantic.
More information about the Ubuntu-reviews
mailing list