[Merge] ~xnox/livecd-rootfs:X13s into livecd-rootfs:ubuntu/master

Steve Langasek mp+452163 at code.launchpad.net
Tue Sep 26 22:04:04 UTC 2023


One comment inline, the rest looks correct to me.

Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index 7896b6f..593b921 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -715,6 +715,10 @@ case $PROJECT in
>  				;;
>  			*)
>  				touch config/universe-enabled
> +				KERNEL_FLAVOURS='generic-hwe-22.04'
> +				if [ "$SUBARCH" = "X13s" ]; then

case-sensitive matching; elsewhere you indicated 'x13s' as the subarch name, which is consistent with other subarch naming even when the subarch is a proper (brand) name.

Uppercase letters are of course prohibited in Debian package names altogether, so the package names will have to be '*x13s*'.  The subarch doesn't have to be consistent with the rules for Debian package names, but I think it would still be less surprising to lower case it.

> +					KERNEL_FLAVOURS='laptop-23.10'
> +				fi
>  				PASSES_TO_LAYERS="true"
>  				# the minimal layer, for minimal installs
>  				add_task minimal minimal standard ubuntu-desktop-minimal ubuntu-desktop-minimal-default-languages


-- 
https://code.launchpad.net/~xnox/livecd-rootfs/+git/livecd-rootfs/+merge/452163
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list