[Merge] ~philroche/livecd-rootfs/+git/livecd-rootfs:bugfix/ubuntu-cpc-unminimize-syntax-error into livecd-rootfs:ubuntu/master

Steve Langasek mp+451637 at code.launchpad.net
Tue Sep 19 15:25:20 UTC 2023


Review: Needs Fixing



Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 21056e1..4b6f008 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -292,6 +292,7 @@ if dpkg-query --show --showformat='${db:Status-Status}\n' ubuntu-server 2> /dev/
>      DEBIAN_FRONTEND=noninteractive apt-get install -y landscape-common
>  fi
>  EOF
> +fi

mismatched indentation, tho.  this should be in line with the start of the 'if' statement below it V

>  
>                  if [ "$PROJECT" = "ubuntu-cpc" ]; then
>                    # we'd like to transform a minimized image to a base image


-- 
https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-rootfs/+merge/451637
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list